From: Leon Romanovsky <leon@kernel.org>
To: Abhijit Gangurde <abhijit.gangurde@amd.com>
Cc: sashiko-reviews@lists.linux.dev, linux-rdma@vger.kernel.org
Subject: Re: [for-next 3/4] RDMA/ionic: allocate a PD-scoped DMA MR
Date: Mon, 16 Nov 2026 15:53:50 +0200 [thread overview]
Message-ID: <20261116135350.GP11319@unreal> (raw)
In-Reply-To: <2770c6d3-f595-5d6b-afec-dfa8fee30697@amd.com>
On Mon, Nov 16, 2026 at 02:47:15PM +0530, Abhijit Gangurde wrote:
>
> On 11/8/26 20:34, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential
> > issue to consider:
> > - [High] RDMA/ionic: build failure in ionic_fill_lif_cfg() due to
> > missing rdma.cap
> > --
> >
> > commit 71ee46b9e5e60e185b9553d17b2722a569d100ad
> > Author: Gregor Dick <gregor.dick@amd.com>
> >
> > RDMA/ionic: allocate a PD-scoped DMA MR
> >
> > This commit allocates a PD-scoped DMA MR via CREATE_MR with
> > IONIC_MRF_DMA_MR when the firmware advertises IONIC_GEN_CAP_DMA_MR.
> >
> > [ ... ]
> >
> > > diff --git a/drivers/infiniband/hw/ionic/ionic_lif_cfg.c b/drivers/infiniband/hw/ionic/ionic_lif_cfg.c
> > > index 66cee57442e7a..dcf54856603d4 100644
> > > --- a/drivers/infiniband/hw/ionic/ionic_lif_cfg.c
> > > +++ b/drivers/infiniband/hw/ionic/ionic_lif_cfg.c
> > > @@ -95,6 +95,7 @@ void ionic_fill_lif_cfg(struct ionic_lif *lif, struct ionic_lif_cfg *cfg)
> > > cfg->rq_expdb =
> > > !!(lif->qtype_info[IONIC_QTYPE_RXQ].features & IONIC_QIDENT_F_EXPDB);
> > > cfg->alloc_qid_cap = ident->rdma.alloc_qid_cap;
> > > + cfg->cap = le64_to_cpu(ident->rdma.cap);
> > > }
> > [Severity: High]
> > Does this break the build when CONFIG_INFINIBAND_IONIC is enabled?
> > The rdma struct inside union ionic_lif_identity in
> > drivers/net/ethernet/pensando/ionic/ionic_if.h has no cap member.
>
> Patch 1/4 adds __le64 cap to ionic_lif_identity.rdma (replacing reserved
> bytes). Patch 3/4 uses that field, so the build succeeds when the series is
> applied in order. This appears to be a series context false positive(?)
I don't know, maybe because net patch was involved.
Thanks
>
> Abhijit
>
>
next prev parent reply other threads:[~2026-11-16 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 15:02 [for-next 0/4] RDMA/ionic: add DMA MR and v2 atomic WQE Abhijit Gangurde
2026-11-07 15:02 ` [for-next 1/4] net: ionic: add an RDMA capability word to the LIF identity Abhijit Gangurde
2026-11-07 15:02 ` [for-next 2/4] RDMA/ionic: preserve atomic operands in the send WQE Abhijit Gangurde
2026-11-07 15:02 ` [for-next 3/4] RDMA/ionic: allocate a PD-scoped DMA MR Abhijit Gangurde
2026-11-08 15:04 ` sashiko-bot
2026-11-16 9:17 ` Abhijit Gangurde
2026-11-16 13:53 ` Leon Romanovsky [this message]
2026-11-07 15:02 ` [for-next 4/4] RDMA/ionic: use the v2 atomic send WQE layout Abhijit Gangurde
2026-11-16 13:54 ` [for-next 0/4] RDMA/ionic: add DMA MR and v2 atomic WQE Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116135350.GP11319@unreal \
--to=leon@kernel.org \
--cc=abhijit.gangurde@amd.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox