Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Tariq Toukan <tariqt@nvidia.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Cc: Gal Pressman <gal@nvidia.com>, Jonathan Corbet <corbet@lwn.net>,
	"Leon Romanovsky" <leon@kernel.org>, <linux-doc@vger.kernel.org>,
	<linux-rdma@vger.kernel.org>, Mark Bloch <mbloch@nvidia.com>,
	Nimrod Oren <noren@nvidia.com>,
	Rahul Rameshbabu <rrameshbabu@nvidia.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Simon Horman <horms@kernel.org>, Tariq Toukan <tariqt@nvidia.com>
Subject: [PATCH net-next 1/2] net/mlx5e: Remove documentation of nonexistent counters
Date: Fri, 20 Nov 2026 10:30:47 +0200	[thread overview]
Message-ID: <20261120083050.2540739-2-tariqt@nvidia.com> (raw)
In-Reply-To: <20261120083050.2540739-1-tariqt@nvidia.com>

From: Gal Pressman <gal@nvidia.com>

- rx_bits_phy never existed.
- rx_mpwqe_frag was removed by [1].
- dev_out_of_buffer never existed, and looks like a duplicate of
  dev_internal_queue_oob.

[1] Commit 7e426671704d ("net/mlx5e: Single flow order-0 pages for
Striding RQ")

Fixes: 8ce3b586faa4 ("net/mlx5: Add counter information to mlx5 driver documentation")
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Nimrod Oren <noren@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
 .../ethernet/mellanox/mlx5/counters.rst       | 28 ++-----------------
 1 file changed, 2 insertions(+), 26 deletions(-)

diff --git a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
index cc498895f92e..026259ae383c 100644
--- a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
+++ b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
@@ -341,14 +341,6 @@ the software port.
      - The number of wrong opcodes received on ring i.
      - Error
 
-   * - `rx[i]_mpwqe_frag`
-     - The number of WQEs that failed to allocate compound page and hence
-       fragmented MPWQE’s (Multi Packet WQEs) were used on ring i. If this
-       counter raise, it may suggest that there is no enough memory for large
-       pages, the driver allocated fragmented pages. This is not abnormal
-       condition.
-     - Informative
-
    * - `rx[i]_mpwqe_filler_cqes`
      - The number of filler CQEs events that were issued on ring i.
      - Informative
@@ -1132,29 +1124,18 @@ like flow control, FEC and more.
      - Failed to allocate a buffer to received packet (or SKB) on ring i.
      - Error
 
-   * - `rx_bits_phy`
-     - This counter provides information on the total amount of traffic that
-       could have been received and can be used as a guideline to measure the
-       ratio of errored traffic in `rx_pcs_symbol_err_phy` and
-       `rx_corrected_bits_phy`.
-     - Informative
-
    * - `rx_pcs_symbol_err_phy`
      - This counter counts the number of symbol errors that wasn’t corrected by
        FEC correction algorithm or that FEC algorithm was not active on this
        interface. If this counter is increasing, it implies that the link
        between the NIC and the network is suffering from high BER, and that
-       traffic is lost. You may need to replace the cable/transceiver. The error
-       rate is the number of `rx_pcs_symbol_err_phy` divided by the number of
-       `rx_bits_phy` on a specific time frame.
+       traffic is lost. You may need to replace the cable/transceiver.
      - Error
 
    * - `rx_corrected_bits_phy`
      - The number of corrected bits on this port according to active FEC
        (RS/FC). If this counter is increasing, it implies that the link between
-       the NIC and the network is suffering from high BER. The corrected bit
-       rate is the number of `rx_corrected_bits_phy` divided by the number of
-       `rx_bits_phy` on a specific time frame.
+       the NIC and the network is suffering from high BER.
      - Error
 
    * - `rx_err_lane_[l]_phy`
@@ -1337,11 +1318,6 @@ Device Counters
      - The number of seconds where `outbound_pci_stalled_wr` was above 30%.
      - Informative
 
-   * - `dev_out_of_buffer`
-     - The number of times the device owned queue had not enough buffers
-       allocated.
-     - Error
-
    * - `pci_bw_inbound_high`
      - The number of times the device crossed the high inbound pcie bandwidth
        threshold. To be compared to pci_bw_inbound_low to check if the device
-- 
2.44.0


  reply	other threads:[~2026-11-20  8:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  8:30 [PATCH net-next 0/2] net/mlx5e: Fix mlx5e counters documentation errors Tariq Toukan
2026-11-20  8:30 ` Tariq Toukan [this message]
2026-11-20  8:34   ` [PATCH net-next 1/2] net/mlx5e: Remove documentation of nonexistent counters sashiko-bot
2026-11-20  8:30 ` [PATCH net-next 2/2] net/mlx5e: Fix incorrect name of rx_symbol_err_phy counter in documentation Tariq Toukan
2026-11-20  8:34   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120083050.2540739-2-tariqt@nvidia.com \
    --to=tariqt@nvidia.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=gal@nvidia.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=noren@nvidia.com \
    --cc=pabeni@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=rrameshbabu@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox