Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Mahanta Jambigi <mjambigi@linux.ibm.com>
To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, alibuda@linux.alibaba.com,
	dust.li@linux.alibaba.com, sidraya@linux.ibm.com
Cc: hidayath@linux.ibm.com, pasic@linux.ibm.com, horms@kernel.org,
	tonylu@linux.alibaba.com, guwen@linux.alibaba.com,
	netdev@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-rdma@vger.kernel.org,
	Mahanta Jambigi <mjambigi@linux.ibm.com>
Subject: [PATCH net-next] net/smc: validate smc_diag_req length before reading diag_ext
Date: Fri, 20 Nov 2026 12:37:08 +0100	[thread overview]
Message-ID: <20261120113708.3950966-1-mjambigi@linux.ibm.com> (raw)

__sock_diag_cmd() only validates nlmsg_len against sizeof(struct
sock_diag_req) (2 bytes). smc_diag_handler_dump() schedules a dump
without a further check, so the dump path reads diag_ext at offset 3 of
struct smc_diag_req from uninitialised skb tailroom. Add the missing
nlmsg_len guard, matching every other sock_diag handler.

Fixes: f16a7dd5cf27 ("smc: netlink interface for SMC sockets")
Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
---
 net/smc/smc_diag.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/smc/smc_diag.c b/net/smc/smc_diag.c
index 15485a08d9a0..ed578279dcd0 100644
--- a/net/smc/smc_diag.c
+++ b/net/smc/smc_diag.c
@@ -245,6 +245,9 @@ static int smc_diag_handler_dump(struct sk_buff *skb, struct nlmsghdr *h)
 {
 	struct net *net = sock_net(skb->sk);

+	if (nlmsg_len(h) < sizeof(struct smc_diag_req))
+		return -EINVAL;
+
 	if (h->nlmsg_type == SOCK_DIAG_BY_FAMILY &&
 	    h->nlmsg_flags & NLM_F_DUMP) {
 		{
-- 
2.50.1 (Apple Git-155)


             reply	other threads:[~2026-11-20 11:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 11:37 Mahanta Jambigi [this message]
2026-11-20 11:40 ` [PATCH net-next] net/smc: validate smc_diag_req length before reading diag_ext sashiko-bot
2026-11-20 11:43 ` netdev-bot+sinfo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120113708.3950966-1-mjambigi@linux.ibm.com \
    --to=mjambigi@linux.ibm.com \
    --cc=alibuda@linux.alibaba.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dust.li@linux.alibaba.com \
    --cc=edumazet@google.com \
    --cc=guwen@linux.alibaba.com \
    --cc=hidayath@linux.ibm.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=sidraya@linux.ibm.com \
    --cc=tonylu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox