From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: mike.marciniszyn@intel.com, Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] infiniband: hw: Drop unnecessary continue
Date: Sat, 3 Mar 2018 10:34:29 -0500 [thread overview]
Message-ID: <2032604b-b25b-e5bf-bea5-3c43a50b8ff7@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1803031506550.2302@hadrien>
On 3/3/2018 9:07 AM, Julia Lawall wrote:
>> diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
>> index 3990f38..1bd3b32 100644
>> --- a/drivers/infiniband/hw/qib/qib_init.c
>> +++ b/drivers/infiniband/hw/qib/qib_init.c
>> @@ -681,7 +681,6 @@ int qib_init(struct qib_devdata *dd, int reinit)
>> if (lastfail) {
>> qib_dev_err(dd,
>> "failed to allocate kernel ctxt's rcvhdrq and/or egr bufs\n");
>> - continue;
>> }
>
> Again, the braces should be dropped too.
Thanks Julia, I just noticed the same thing! :)
-Denny
next prev parent reply other threads:[~2018-03-03 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 13:03 [PATCH] infiniband: hw: Drop unnecessary continue Arushi Singhal
2018-03-03 14:07 ` [Outreachy kernel] " Julia Lawall
2018-03-03 15:34 ` Dennis Dalessandro [this message]
2018-03-03 15:32 ` Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2032604b-b25b-e5bf-bea5-3c43a50b8ff7@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=arushisinghal19971997@gmail.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox