From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25E7D152518 for ; Fri, 3 May 2024 15:23:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714749804; cv=none; b=Uvwzlf0PD/y3IYpYR0Pj5Ne4x+gSAxYzkB46e9YDpHdJk/eD4tpwGCKCfFTwogAalSrvIpp9CloaaAdebq1dyTtpXVsMuaWpuauDpyjDFPLqd2SqqUpQuhAmJILLjaQE1K3zv4O3NyWQbPyJHzi1cBaUyKSCQCtf8GPDmYfn4tM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714749804; c=relaxed/simple; bh=MWE7coWNqMXJleIi3yjk5awPC1JbvNBfC0e959nu6Uk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pk+fb8f/oh8yqf78gaSVTVxRsDf0benixSG2Yun5XjDrY/9Izdzs1767MY2+ZAdQqBYlw+wF/+xKbOtMI4z4bva+YhSuiXjhFMBHfE5EoMu3d36d/oqQ/mcXsn00R6XuPIUIeAdWq67HjrJr5HY0HOtBFE81zYM3wbRBUyihNZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Y/j/j6+v; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y/j/j6+v" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-34dc8d3fbf1so2065611f8f.1 for ; Fri, 03 May 2024 08:23:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714749799; x=1715354599; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wdt2IfwqtFqaZTN79e9iL9j98LJEO7sDYqEbNeYYJaU=; b=Y/j/j6+v+RdKlz+2pP3ymSgVEMbJ8j/qzOcA0Qq2cYiciXErsGU/SXG/CckecyQBUu 7RXrir2aGnW4b+wadjF/S30K0hPBvLdg/MqW9kE3tGydDhz2dPuCia3rNhmdCfFQFl5d WsgNFBtL3kZO/rdBy+q3xa2NF9wDQd6oPXB+AOTdL/n/tLr69XL/PIP2wsDSd10ow3K5 NS5FwZrLxVridIy6/2cF+nWqgj0JHc4xB9QBd+lAkHH7rKKzavPQrFwE2+oJxv9yZEGt +fnYU+iQsK5j3VurttRSYvazrqYpZSZ8aC1HnSI2A9I+KWM2DKZcUGkMtCyZlj9gMMQQ BQ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714749799; x=1715354599; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wdt2IfwqtFqaZTN79e9iL9j98LJEO7sDYqEbNeYYJaU=; b=kMsZzfY8Rs3SFypz8Xj6B7fYdE8fKCVotfzhCSBt4VyueeczfUxws3a3RrRlnzz/e0 PpnrI+uOxnhMk7v93Fd+pnWxKM9gZO/ziNh5pj24uOpgxPQlSvek2Y38x3l5/UdQtXpu eEhAvqrGeIjfxPr2bvBDwuuwrGCllcDxOXbsPndwJmrJY/E0HhauJISHa4MUBtbDypWx NLo92EX4E/OyUgAnJ9m3owMa/2OczebNAWx+rK4qCPaMS34mC1Vwafv95v/5UAzeJIeX jv9Ju6NKontuYcHnWaGHUVpVuG2FWi27nZkPcy6fwLWHxnEc1WXGyDEjHx86hSIgPGV4 piLg== X-Forwarded-Encrypted: i=1; AJvYcCV1z8RSk8zjv/PlJDV+gaQ/2ECby6z3TdX4S6nQ6qjq43q9yMNhRzO7LQW8VPurcFZRICgtSVLEdRKddAIbkmhSfAUuyge8Jkra+w== X-Gm-Message-State: AOJu0YyJRvsFzjeo+KOMgmSosSos2heL+3ZCBfvXK4Y+kznxlfxJmwEZ agWI2rFfmmO7yuL2Z+nHWHKbQtl8mc7F7w14W7zLUY1SoG8wapzBNh0d4NFksIo= X-Google-Smtp-Source: AGHT+IF9s4k+fRR7e1yxXvSlCXD3nF/jRBs6Gtlty++TWU+4zWj+bqwN6oJg1Acr4XwoE1SLANszRA== X-Received: by 2002:a5d:6a8c:0:b0:34c:5af8:e491 with SMTP id s12-20020a5d6a8c000000b0034c5af8e491mr2016677wru.33.1714749799241; Fri, 03 May 2024 08:23:19 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id p12-20020adfe60c000000b0034ccd06a6a3sm4011645wrm.18.2024.05.03.08.23.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 08:23:18 -0700 (PDT) Date: Fri, 3 May 2024 18:23:14 +0300 From: Dan Carpenter To: Joel Granados Cc: Sabrina Dubroca , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Aring , Stefan Schmidt , Miquel Raynal , David Ahern , Steffen Klassert , Herbert Xu , Matthieu Baerts , Mat Martineau , Geliang Tang , Remi Denis-Courmont , Allison Henderson , David Howells , Marc Dionne , Marcelo Ricardo Leitner , Xin Long , Wenjia Zhang , Jan Karcher , "D. Wythe" , Tony Lu , Wen Gu , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Jon Maloy , Ying Xue , Martin Schiller , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , Simon Horman , Julian Anastasov , Joerg Reuter , Luis Chamberlain , Kees Cook , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dccp@vger.kernel.org, linux-wpan@vger.kernel.org, mptcp@lists.linux.dev, linux-hams@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-afs@lists.infradead.org, linux-sctp@vger.kernel.org, linux-s390@vger.kernel.org, linux-nfs@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-x25@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, lvs-devel@vger.kernel.org Subject: Re: [PATCH net-next v6 8/8] ax.25: x.25: Remove the now superfluous sentinel elements from ctl_table array Message-ID: <21f76a94-1b35-4cf7-914d-e341848b0b9e@moroto.mountain> References: <20240501-jag-sysctl_remset_net-v6-0-370b702b6b4a@samsung.com> <20240501-jag-sysctl_remset_net-v6-8-370b702b6b4a@samsung.com> <20240503121811.fsmriwsgugzm2o7i@joelS2.panther.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503121811.fsmriwsgugzm2o7i@joelS2.panther.com> On Fri, May 03, 2024 at 02:18:11PM +0200, Joel Granados wrote: > On Wed, May 01, 2024 at 03:15:54PM +0200, Sabrina Dubroca wrote: > > 2024-05-01, 11:29:32 +0200, Joel Granados via B4 Relay wrote: > > > From: Joel Granados > > > diff --git a/net/ax25/ax25_ds_timer.c b/net/ax25/ax25_ds_timer.c > > > index c4f8adbf8144..c50a58d9e368 100644 > > > --- a/net/ax25/ax25_ds_timer.c > > > +++ b/net/ax25/ax25_ds_timer.c > > > @@ -55,6 +55,7 @@ void ax25_ds_set_timer(ax25_dev *ax25_dev) > > > ax25_dev->dama.slave_timeout = > > > msecs_to_jiffies(ax25_dev->values[AX25_VALUES_DS_TIMEOUT]) / 10; > > > mod_timer(&ax25_dev->dama.slave_timer, jiffies + HZ); > > > + return; > > > > nit: return not needed here since we're already at the bottom of the > > function, but probably not worth a repost of the series. > > > Thx. I will not repost, but I have changed them locally so they are > there in case a V7 is required. > It's a checkpatch.pl -f warning so we probably will want to fix it eventually. regards, dan carpenter