From: David Ahern <dsahern@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>
Cc: Donald Hunter <donald.hunter@gmail.com>,
Simon Horman <horms@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
Shuah Khan <shuah@kernel.org>,
"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Or Har-Toov <ohartoov@nvidia.com>,
Carolina Jubran <cjubran@nvidia.com>,
Moshe Shemesh <moshe@nvidia.com>, Shay Drori <shayd@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
Daniel Zahka <daniel.zahka@gmail.com>,
Shahar Shitrit <shshitrit@nvidia.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Cosmin Ratiu <cratiu@nvidia.com>, Parav Pandit <parav@nvidia.com>,
Kees Cook <kees@kernel.org>,
Adithya Jayachandran <ajayachandra@nvidia.com>,
Daniel Jurgens <danielj@nvidia.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kselftest@vger.kernel.org, Gal Pressman <gal@nvidia.com>,
Ido Schimmel <idosch@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
Petr Machata <petrm@nvidia.com>
Subject: Re: [PATCH iproute2-next 0/7] devlink: add per-port resource support
Date: Sun, 28 Jun 2026 11:14:04 -0600 [thread overview]
Message-ID: <225e2dfb-d4af-4b86-a233-9c0ee9c1da2b@kernel.org> (raw)
In-Reply-To: <20260609053953.487152-1-tariqt@nvidia.com>
On 6/8/26 11:39 PM, Tariq Toukan wrote:
> Hi,
>
> Currently, devlink resource show only supports querying a specific
> device and displays device-level resources. However, some resources
> are per-port, such as the maximum number of SFs that can be created
> on a specific PF port.
>
> This series extends devlink resource show with full support for
> port-level resources, including a dump mode, per-port querying syntax,
> and scope filtering. In preparation for these features, the first two
> patches refactor how dpipe tables are handled to unblock dump support
> and ensure errors in secondary queries are non-fatal.
>
> The series is organized as follows:
>
> Patch 1 splits the dpipe tables display into a separate function.
>
> Patch 2 moves the dpipe tables query into the per-device resource show
> callback, ensuring it behaves correctly during a multi-device dump.
>
> Patch 3 fixes a pre-existing memory leak in resource_ctx_fini.
>
> Patch 4 adds dump support to resource show (no device required).
>
> Patch 5 shows port-level resources returned in a dump reply.
>
> Patch 6 adds DEV/PORT_INDEX syntax to resource show.
>
> Patch 7 adds scope filter to resource show.
>
> With this series, users can query resources at all levels:
>
> $ devlink resource show
> pci/0000:03:00.0:
> name local_max_SFs size 508 unit entry
> name external_max_SFs size 508 unit entry
> pci/0000:03:00.0/196608:
> name max_SFs size 20 unit entry
>
> $ devlink resource show scope dev
> pci/0000:03:00.0:
> name local_max_SFs size 508 unit entry
> name external_max_SFs size 508 unit entry
>
> $ devlink resource show scope port
> pci/0000:03:00.0/196608:
> name max_SFs size 20 unit entry
>
> $ devlink resource show pci/0000:03:00.0/196608
> pci/0000:03:00.0/196608:
> name max_SFs size 20 unit entry
>
> This series is the userspace counterpart to the kernel series:
> https://lore.kernel.org/all/20260407194107.148063-1-tariqt@nvidia.com/
>
> Ido Schimmel (2):
> devlink: Split dpipe tables output to a separate function
> devlink: Move dpipe tables query to resources show callback
>
> Or Har-Toov (5):
> devlink: fix memory leak in resource_ctx_fini
> devlink: add dump support for resource show
> devlink: show port resources in resource dump
> devlink: add per-port resource show support
> devlink: add scope filter to resource show
>
> bash-completion/devlink | 8 ++
> devlink/devlink.c | 202 +++++++++++++++++++++++++++---------
> man/man8/devlink-resource.8 | 34 +++++-
> 3 files changed, 192 insertions(+), 52 deletions(-)
>
>
> base-commit: 7340b539841dc739bc0b813e8e86825bc1eb5a4c
applied to iproute2-next with the fixup recommended by Claude and
confirmed by Or
prev parent reply other threads:[~2026-06-28 17:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 5:39 [PATCH iproute2-next 0/7] devlink: add per-port resource support Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 1/7] devlink: Split dpipe tables output to a separate function Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 2/7] devlink: Move dpipe tables query to resources show callback Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 3/7] devlink: fix memory leak in resource_ctx_fini Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 4/7] devlink: add dump support for resource show Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 5/7] devlink: show port resources in resource dump Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 6/7] devlink: add per-port resource show support Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 7/7] devlink: add scope filter to resource show Tariq Toukan
2026-06-11 18:53 ` David Ahern
2026-06-14 12:02 ` Or Har-Toov
2026-06-14 12:10 ` Or Har-Toov
2026-06-28 17:14 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=225e2dfb-d4af-4b86-a233-9c0ee9c1da2b@kernel.org \
--to=dsahern@kernel.org \
--cc=ajayachandra@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=chuck.lever@oracle.com \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=cratiu@nvidia.com \
--cc=daniel.zahka@gmail.com \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ohartoov@nvidia.com \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=petrm@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
--cc=shshitrit@nvidia.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stephen@networkplumber.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox