public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Chao Leng <lengchao@huawei.com>
To: <jgg@nvidia.com>, <leon@kernel.org>
Cc: <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] infiniband:cma: change iboe packet life time from 18 to 16
Date: Fri, 2 Dec 2022 14:31:20 +0800	[thread overview]
Message-ID: <227d7bf5-d8da-8a0f-0835-7bfb7d5672fb@huawei.com> (raw)
In-Reply-To: <20221125010026.755-1-lengchao@huawei.com>

Hi, jason
     Gently ping, thank you.

On 2022/11/25 9:00, Chao Leng wrote:
> The ack timeout retransmission time is affected by the following two
> factors: one is packet life time, another is the HCA processing time.
> Now the default packet lifetime(CMA_IBOE_PACKET_LIFETIME) is 18.
> That means the minimum ack timeout is 2 seconds(2^(18+1)*4us=2.097seconds).
> The packet lifetime means the maximum transmission time of packets
> on the network, 2 seconds is too long.
> Assume the network is a clos topology with three layers, every packet
> will pass through five hops of switches. Assume the buffer of every
> switch is 128MB and the port transmission rate is 25 Gbit/s,
> the maximum transmission time of the packet is 200ms(128MB*5/25Gbit/s).
> Add double redundancy, it is less than 500ms.
> So change the CMA_IBOE_PACKET_LIFETIME to 16,
> the maximum transmission time of the packet will be about 500+ms,
> it is long enough.
> 
> Signed-off-by: Chao Leng <lengchao@huawei.com>
> ---
>   drivers/infiniband/core/cma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> index cc2222b85c88..2f5b5e6f3d11 100644
> --- a/drivers/infiniband/core/cma.c
> +++ b/drivers/infiniband/core/cma.c
> @@ -47,7 +47,7 @@ MODULE_LICENSE("Dual BSD/GPL");
>   #define CMA_CM_RESPONSE_TIMEOUT 20
>   #define CMA_MAX_CM_RETRIES 15
>   #define CMA_CM_MRA_SETTING (IB_CM_MRA_FLAG_DELAY | 24)
> -#define CMA_IBOE_PACKET_LIFETIME 18
> +#define CMA_IBOE_PACKET_LIFETIME 16
>   #define CMA_PREFERRED_ROCE_GID_TYPE IB_GID_TYPE_ROCE_UDP_ENCAP
>   
>   static const char * const cma_events[] = {
> 

  reply	other threads:[~2022-12-02  6:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25  1:00 [PATCH] infiniband:cma: change iboe packet life time from 18 to 16 Chao Leng
2022-12-02  6:31 ` Chao Leng [this message]
2022-12-07 23:48 ` Jason Gunthorpe
2022-12-22 16:35   ` Suri Shelvapille

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=227d7bf5-d8da-8a0f-0835-7bfb7d5672fb@huawei.com \
    --to=lengchao@huawei.com \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox