public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Allison Henderson <allison.henderson@oracle.com>
To: "edumazet@google.com" <edumazet@google.com>,
	"linux@treblig.org" <linux@treblig.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"kuba@kernel.org" <kuba@kernel.org>
Cc: "rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'
Date: Tue, 4 Jun 2024 17:51:48 +0000	[thread overview]
Message-ID: <2442cae88ee4a5f7ba46bb0158735634fa82a305.camel@oracle.com> (raw)
In-Reply-To: <20240531233307.302571-1-linux@treblig.org>

On Sat, 2024-06-01 at 00:33 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'rds_ib_dereg_odp_mr' has been unused since the original
> commit 2eafa1746f17 ("net/rds: Handle ODP mr
> registration/unregistration").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

This patch looks fine to me, the struct is indeed unused at this point.
Thanks for the clean up!

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
>  net/rds/ib_rdma.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
> index 8f070ee7e742..d1cfceeff133 100644
> --- a/net/rds/ib_rdma.c
> +++ b/net/rds/ib_rdma.c
> @@ -40,10 +40,6 @@
>  #include "rds.h"
>  
>  struct workqueue_struct *rds_ib_mr_wq;
> -struct rds_ib_dereg_odp_mr {
> -       struct work_struct work;
> -       struct ib_mr *mr;
> -};
>  
>  static void rds_ib_odp_mr_worker(struct work_struct *work);
>  


  parent reply	other threads:[~2024-06-04 17:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31 23:33 [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr' linux
2024-06-04 17:08 ` Simon Horman
2024-06-04 17:32   ` Dr. David Alan Gilbert
2024-06-04 17:51 ` Allison Henderson [this message]
2024-07-20  0:28   ` Dr. David Alan Gilbert
2024-07-21  7:05     ` Leon Romanovsky
2024-07-21 11:02       ` Dr. David Alan Gilbert
2024-07-21 12:06         ` Leon Romanovsky
2024-07-29 21:01           ` Dr. David Alan Gilbert
2024-07-21  6:41 ` Zhu Yanjun
2024-07-21 10:59   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2442cae88ee4a5f7ba46bb0158735634fa82a305.camel@oracle.com \
    --to=allison.henderson@oracle.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rds-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox