From: Markus Elfring <Markus.Elfring@web.de>
To: Xiyu Yang <xiyuyang19@fudan.edu.cn>,
Xin Tan <tanxin.ctf@gmail.com>,
linux-rdma@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Faisal Latif <faisal.latif@intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kangjie Lu <kjlu@umn.edu>,
Leon Romanovsky <leon@kernel.org>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Yuan Zhang <yuanxzhang@fudan.edu.cn>
Subject: Re: [PATCH v3] infiniband: i40iw: fix a potential NULL pointer dereference
Date: Sat, 28 Dec 2019 20:50:07 +0100 [thread overview]
Message-ID: <29610962-92d4-2989-f18c-fa4a0a13ccb4@web.de> (raw)
In-Reply-To: <1577366516-19556-1-git-send-email-xiyuyang19@fudan.edu.cn>
> in_dev_get may return a NULL object.
I would prefer a wording like “A null pointer can be returned by in_dev_get().”.
> The fix handles the situation
> by adding a check to avoid NULL pointer dereference on idev,
> as pick_local_ipaddrs does.
How do you think about the wording suggestion “Thus add a corresponding check
so that a null pointer dereference will be avoided at this place.”?
Please add also the tag “Fixes” to your change description.
Regards,
Markus
prev parent reply other threads:[~2019-12-28 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 13:21 [PATCH v3] infiniband: i40iw: fix a potential NULL pointer dereference xiyuyang19
2019-12-26 14:40 ` Leon Romanovsky
2019-12-28 19:50 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29610962-92d4-2989-f18c-fa4a0a13ccb4@web.de \
--to=markus.elfring@web.de \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=jgg@ziepe.ca \
--cc=kjlu@umn.edu \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
--cc=tanxin.ctf@gmail.com \
--cc=xiyuyang19@fudan.edu.cn \
--cc=yuanxzhang@fudan.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox