Re: [PATCH net-next 5/8] net: core: dev: Add extack argument to __dev_change_flags()

[David Ahern <dsa@cumulusnetworks.com>]

On 12/5/18 3:51 AM, Petr Machata wrote:
> In order to pass extack together with NETDEV_PRE_UP notifications, it's
> necessary to route the extack to __dev_open() from diverse (possibly
> indirect) callers. The last missing API is __dev_change_flags().
> 
> Therefore extend __dev_change_flags() with and extra extack argument and
> update the two existing users.
> 
> Since the function declaration line is changed anyway, name the struct
> net_device argument to placate checkpatch.
> 
> Signed-off-by: Petr Machata <petrm@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> Reviewed-by: Ido Schimmel <idosch@mellanox.com>
> ---
>  include/linux/netdevice.h | 3 ++-
>  net/core/dev.c            | 5 +++--
>  net/core/rtnetlink.c      | 3 ++-
>  3 files changed, 7 insertions(+), 4 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@gmail.com>