From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Subject: Re: [PATCH v2 1/6] mm: get_user_pages: consolidate error handling Date: Mon, 2 Jul 2018 14:34:48 -0700 Message-ID: <2bb69d70-33c4-3547-823d-4750df237d83@nvidia.com> References: <20180702005654.20369-1-jhubbard@nvidia.com> <20180702005654.20369-2-jhubbard@nvidia.com> <20180702101725.esnjyo4zp3726i3n@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180702101725.esnjyo4zp3726i3n@quack2.suse.cz> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jan Kara , john.hubbard@gmail.com Cc: Matthew Wilcox , Michal Hocko , Christopher Lameter , Jason Gunthorpe , Dan Williams , linux-mm@kvack.org, LKML , linux-rdma , linux-fsdevel@vger.kernel.org List-Id: linux-rdma@vger.kernel.org On 07/02/2018 03:17 AM, Jan Kara wrote: > On Sun 01-07-18 17:56:49, john.hubbard@gmail.com wrote: >> From: John Hubbard >> >> An upcoming patch requires a way to operate on each page that >> any of the get_user_pages_*() variants returns. >> >> In preparation for that, consolidate the error handling for >> __get_user_pages(). This provides a single location (the "out:" label) >> for operating on the collected set of pages that are about to be returned. >> >> As long every use of the "ret" variable is being edited, rename >> "ret" --> "err", so that its name matches its true role. >> This also gets rid of two shadowed variable declarations, as a >> tiny beneficial a side effect. >> >> Signed-off-by: John Hubbard > > This looks nice! You can add: > > Reviewed-by: Jan Kara > Great, thanks for the review! -- John Hubbard NVIDIA