From: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 16/20] IB/hfi1: Add receive fault injection feature
Date: Fri, 3 Mar 2017 12:02:39 -0500 [thread overview]
Message-ID: <2ded92a7-27e3-f472-46f8-f0921d122f15@intel.com> (raw)
In-Reply-To: <20170303161508.GF14379-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On 03/03/2017 11:15 AM, Leon Romanovsky wrote:
> On Thu, Mar 02, 2017 at 10:26:17AM -0800, Dennis Dalessandro wrote:
>> From: Don Hiatt <don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>
>> Add fault injection capability:
>> - Drop packets unconditionally (fault_by_packet)
>> - Drop packets based on opcode (fault_by_opcode)
>>
>> This feature reacts to the global FAULT_INJECTION
>> config flag.
>>
>> The faulting traces have been added:
>> - misc/fault_opcode
>> - misc/fault_packet
>>
>> See 'Documentation/fault-injection/fault-injection.txt'
>> for details.
>>
>> Examples:
>> - Dropping packets by opcode:
>> /sys/kernel/debug/hfi1/hfi1_X/fault_opcode
>> # Enable fault
>> echo Y > fault_by_opcode
>> # Setprobability of dropping (0-100%)
>> # echo 25 > probability
>> # Set opcode
>> echo 0x64 > opcode
>> # Number of times to fault
>> echo 3 > times
>> # An optional mask allows you to fault
>> # a range of opcodes
>> echo 0xf0 > mask
>> /sys/kernel/debug/hfi1/hfi1_X/fault_stats
>> contains a value in parentheses to indicate
>> number of each opcode dropped.
>>
>> - Dropping packets unconditionally
>> /sys/kernel/debug/hfi1/hfi1_X/fault_packet
>> # Enable fault
>> echo Y > fault_by_packet
>> /sys/kernel/debug/hfi1/hfi1_X/fault_packet/fault_stats
>> contains the number of packets dropped.
>
> It will be so nice to have this functionality extended to objects and
> placed in IB/core. For example, VNIC and IPoIB will be able to use
> faults by packet, while all other drivers and ULPs will use faults by
> objects.
>
> Does it make sense?
I agree. We also should think about a subsystem wide approach for things
like this, and other forms of debugging.
-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-03 17:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 18:21 [PATCH 00/20] IB/hfi1, qib, rdmavt: Another round of patches for 4.11 Dennis Dalessandro
[not found] ` <20170301181719.29989.31238.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-03-01 18:21 ` [PATCH 01/20] IB/hfi1: Force logical link down Dennis Dalessandro
2017-03-01 18:21 ` [PATCH 02/20] IB/hfi1: Race hazard avoidance in user SDMA driver Dennis Dalessandro
2017-03-01 18:21 ` [PATCH 03/20] IB/hfi1: Cache registers during state change Dennis Dalessandro
2017-03-01 18:21 ` [PATCH 04/20] IB/hfi1: NULL pointer dereference when freeing rhashtable Dennis Dalessandro
2017-03-01 18:22 ` [PATCH 05/20] IB/rdmavt, IB/hfi1, IB/qib: Make wc opcode translation driver dependent Dennis Dalessandro
2017-03-01 18:22 ` [PATCH 06/20] IB/rdmavt: Add additional fields to post send trace Dennis Dalessandro
2017-03-01 18:22 ` [PATCH 07/20] IB/rdmavt: Add tracing for cq entry and poll Dennis Dalessandro
2017-03-01 18:22 ` [PATCH 08/20] IB/rdmavt: Add swqe completion trace Dennis Dalessandro
2017-03-01 18:22 ` [PATCH 09/20] IB/hfi1: Check device id early during init Dennis Dalessandro
2017-03-01 18:22 ` [PATCH 10/20] IB/hfi1: Protect the global dev_cntr_names and port_cntr_names Dennis Dalessandro
2017-03-01 18:22 ` [PATCH 11/20] IB/hfi1: Check for QSFP presence before attempting reads Dennis Dalessandro
2017-03-01 18:23 ` [PATCH 12/20] IB/hfi1: Add a patch value to the firmware version string Dennis Dalessandro
2017-03-01 18:23 ` [PATCH 13/20] IB/rdmavt,IB/hfi1: Fix timer migration regressions Dennis Dalessandro
2017-03-01 18:23 ` [PATCH 14/20] IB/rdmavt: Avoid reseting wqe send_flags in unreserve Dennis Dalessandro
2017-03-01 18:23 ` [PATCH 15/20] IB/hfi1: Ensure VL index is within bounds Dennis Dalessandro
2017-03-01 18:23 ` [PATCH 16/20] IB/hfi1: Add receive fault injection feature Dennis Dalessandro
[not found] ` <20170301182344.29989.12032.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-03-02 17:19 ` Dennis Dalessandro
2017-03-01 18:23 ` [PATCH 17/20] IB/hfi1: Add transmit " Dennis Dalessandro
2017-03-01 18:24 ` [PATCH 18/20] IB/hfi1: Eliminate synchronize_rcu() in mr delete Dennis Dalessandro
2017-03-01 18:24 ` [PATCH 19/20] IB/rdmavt, IB/qib, IB/hfi1: Make percpu refcount optional for user MRs Dennis Dalessandro
2017-03-01 18:24 ` [PATCH 20/20] IB/core: If the MGID/MLID pair is not on the list return an error Dennis Dalessandro
[not found] ` <20170301182426.29989.77369.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-03-02 14:00 ` Leon Romanovsky
[not found] ` <20170302140028.GE9525-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-03-02 15:01 ` Dennis Dalessandro
[not found] ` <4d49f7ab-5bc5-029c-4321-fd349c9dc0f8-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-03-02 15:13 ` Leon Romanovsky
2017-03-02 15:18 ` [PATCH v2 " Dennis Dalessandro
2017-03-02 18:26 ` [PATCH v2 16/20] IB/hfi1: Add receive fault injection feature Dennis Dalessandro
[not found] ` <20170302182610.28851.42687.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-03-03 16:15 ` Leon Romanovsky
[not found] ` <20170303161508.GF14379-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-03-03 17:02 ` Dennis Dalessandro [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-21 0:24 [PATCH v2 00/20] IB/hfi1, qib, rdmavt: Another round of patches for 4.11 Dennis Dalessandro
[not found] ` <20170321001900.28538.38175.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-03-21 0:26 ` [PATCH v2 16/20] IB/hfi1: Add receive fault injection feature Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ded92a7-27e3-f472-46f8-f0921d122f15@intel.com \
--to=dennis.dalessandro-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).