From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9481CC04E69 for ; Wed, 16 Aug 2023 11:35:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244629AbjHPLe4 (ORCPT ); Wed, 16 Aug 2023 07:34:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244644AbjHPLea (ORCPT ); Wed, 16 Aug 2023 07:34:30 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E9B32727 for ; Wed, 16 Aug 2023 04:33:55 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id e9e14a558f8ab-34aa2883f1cso9512795ab.3 for ; Wed, 16 Aug 2023 04:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1692185634; x=1692790434; h=cc:to:subject:message-id:date:thread-index:mime-version:in-reply-to :references:from:from:to:cc:subject:date:message-id:reply-to; bh=EoG/a4ZldJgHSHVfB7HlhSspz+9VDSygTbAyg7+anAQ=; b=cw3HveXFPxinUZsgJQ8XUpAbK92m1n+QZQlh987z67oR4klaQdyeY9hqOqeV5O0xEb 7zwtE1rX/HnkclJJe8TD/+POhDgNe+ia0fxoSvjccgdzVUVl+JGyRZYJTWK7NY0Vp32m ec2LwZrp/eJq1NN+LmzdxDH3oUA3B3zl8CfYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692185634; x=1692790434; h=cc:to:subject:message-id:date:thread-index:mime-version:in-reply-to :references:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EoG/a4ZldJgHSHVfB7HlhSspz+9VDSygTbAyg7+anAQ=; b=NlL5h9vXZRu34BJbkkPhij4mVy032cvT1b0aLw9U5vY5D52qLKNGPfO89N6q/BfSNR ORRwKK2GQ9JVlQW/AvANW6o0JHMv0f2B5xMKqisDS2TIEHVyAhmjEyho9E3I3yX9cTWp 0qo7S7XjBcO/zzeFtLUDX8uRPidyqViGk6WzMuzoYSALAQNm1IyvKh84v0BDw487UlsF i1qlTsf31uaE8V7lT3uveE24KJVRS2JCwmEHrWR9Gu0sjmakBr3hf+EfSe3mEs8/ZPjG ERoFXKil1N0ZNTMtKaKghh0Ms49Z5l9TfuybLsYLk21pT7JRXDZwr2qZbigATHXRx9pK gVHg== X-Gm-Message-State: AOJu0Yzs1R2k42OtU91kPl6LxvWR2DriXYDllza+3b1WmpltNMNl1OyR 5uCQisva6biz/k5h8eB1LWOT91WtEdkGAJV4B1VWWg== X-Google-Smtp-Source: AGHT+IEMvPP4XEEqjFsKl8B1rnuCzayFIWzhtcgm/xmcKww0vdUiIjWUgIe8fdrIYO11TOjmzVs9eEwcfWMh4fVBAcM= X-Received: by 2002:a05:6e02:13d2:b0:349:3e2:ee50 with SMTP id v18-20020a056e0213d200b0034903e2ee50mr1981402ilj.7.1692185634636; Wed, 16 Aug 2023 04:33:54 -0700 (PDT) From: Saravanan Vajravel References: <921cd1d9-2879-f455-1f50-0053fe6a6655@cornelisnetworks.com> <91d94243-3741-0098-cd3c-a6ebc8f21cf2@grimberg.me> <94a8b56d-0f9e-b75b-78d7-753122dcb3b0@grimberg.me> In-Reply-To: <94a8b56d-0f9e-b75b-78d7-753122dcb3b0@grimberg.me> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGARhFlRJdvE4NsRpa1gch6MZ1PegIe4MozAeduyMEBMWlFq7B2IOuA Date: Wed, 16 Aug 2023 17:03:51 +0530 Message-ID: <2e2978cdc824c20f212708139c8b2af7@mail.gmail.com> Subject: RE: isert patch leaving resources behind To: Sagi Grimberg , Dennis Dalessandro , OFED mailing list Cc: Ehab Ababneh , Selvin Xavier , leon@kernel.org Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000aabf3b060308abe0" Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org --000000000000aabf3b060308abe0 Content-Type: text/plain; charset="UTF-8" >> You should look at the DEVICE_REMOVAL cm handler, it should call >> iscsit_cause_connection_reinstatement. I do think that it needs to pass >> it sleep=true (for device removal) so that it will wait for >> conn_wait_comp... Ok. So it should take care of current resource leak issue. Right? Thanks & Regards, Saravanan Vajravel +91-80-46116256 -----Original Message----- From: Sagi Grimberg Sent: Monday, August 14, 2023 6:07 PM To: Saravanan Vajravel ; Dennis Dalessandro ; OFED mailing list Cc: Ehab Ababneh ; Selvin Xavier ; leon@kernel.org Subject: Re: isert patch leaving resources behind On 8/14/23 14:20, Saravanan Vajravel wrote: > Hi Sagi, > > In surprise removal case as well, isert_free_conn() should get invoked > by iSCSI target module. Right? I am trying to understand how the > kernel object leak is possible. In your proposed patch, isert_conn is > released in > isert_wait_conn() handler. Again, isert module tries to release the > connection in isert_free_conn() handler as well. Hence it will lead > use-after-free issue. > > Following are the snippet of iSCSI functions where iscsit_wait_conn() > and > iscsit_free_conn() handlers are invoked in files iscsi_target_login.c > & iscsi_target.c. We need to review if there is a possibility that > iscsit_free_conn() is not invoked in any case. If yes, we may have to > fix that. > > void iscsi_target_login_sess_out > { > . > . > . > if (conn->conn_transport->iscsit_wait_conn) > conn->conn_transport->iscsit_wait_conn(conn); > > if (conn->conn_transport->iscsit_free_conn) > conn->conn_transport->iscsit_free_conn(conn); > . > } > > int iscsit_close_connection( > struct iscsit_conn *conn) > { > . > . > . > if (conn->conn_transport->iscsit_wait_conn) > conn->conn_transport->iscsit_wait_conn(conn); > . > . > . > if (conn->conn_transport->iscsit_free_conn) > conn->conn_transport->iscsit_free_conn(conn); > . > . > } > > @Leon, > > I don't have the kernel logs in hand now. We can reproduce the issue > and share. You should look at the DEVICE_REMOVAL cm handler, it should call iscsit_cause_connection_reinstatement. I do think that it needs to pass it sleep=true (for device removal) so that it will wait for conn_wait_comp... --000000000000aabf3b060308abe0 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQfwYJKoZIhvcNAQcCoIIQcDCCEGwCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3WMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBV4wggRGoAMCAQICDDPW1cVntFGljCZAOzANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwOTE0NTZaFw0yNTA5MTAwOTE0NTZaMIGa MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xGzAZBgNVBAMTElNhcmF2YW5hbiBWYWpyYXZlbDEuMCwGCSqG SIb3DQEJARYfc2FyYXZhbmFuLnZhanJhdmVsQGJyb2FkY29tLmNvbTCCASIwDQYJKoZIhvcNAQEB BQADggEPADCCAQoCggEBAOWUDY8+1Pq6qzzsf5oTzGO7etyb0HT08NkGz7Ymb6gL2BcSxf00xj2f fgOR3x1R5vZCQL+NXGnk27IMYe6P1jT2e49wq24CtJxpjbdCgiY+wM0iowrqj+xHJyGEyFK7BEOB 1cEV+/7fNvlT+wzsiB6LI7YO2jnJoqRyxiuCXWXQteLT5u5dJd79gUxenL2sOdzc9QDElI3VQMfh lU2WOYSpsHwmuzI2n56f4qqAd0KTzesYpT4jUkHrpARqokmK62nwak/mVjpP1xxKkerBRTDplTRj PPaP6wQe1OY7fOWrqgKUrMkQ8uzH68KFHiA/+zIzyFmYwY+S3kdoi+SvK08CAwEAAaOCAeAwggHc MA4GA1UdDwEB/wQEAwIFoDCBowYIKwYBBQUHAQEEgZYwgZMwTgYIKwYBBQUHMAKGQmh0dHA6Ly9z ZWN1cmUuZ2xvYmFsc2lnbi5jb20vY2FjZXJ0L2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy dDBBBggrBgEFBQcwAYY1aHR0cDovL29jc3AuZ2xvYmFsc2lnbi5jb20vZ3NnY2NyM3BlcnNvbmFs c2lnbjJjYTIwMjAwTQYDVR0gBEYwRDBCBgorBgEEAaAyASgKMDQwMgYIKwYBBQUHAgEWJmh0dHBz Oi8vd3d3Lmdsb2JhbHNpZ24uY29tL3JlcG9zaXRvcnkvMAkGA1UdEwQCMAAwSQYDVR0fBEIwQDA+ oDygOoY4aHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAy MC5jcmwwKgYDVR0RBCMwIYEfc2FyYXZhbmFuLnZhanJhdmVsQGJyb2FkY29tLmNvbTATBgNVHSUE DDAKBggrBgEFBQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQU 0Bq3qvsz+PB5FAu5iL1KRdtSBTgwDQYJKoZIhvcNAQELBQADggEBAHXOk8r6/lLV2Fb8uE3tUP2E MFD67H9X0roxhLywKzY+SM6abiUqsRxlcBwNgp0r/SwFG1o+frLlj7gynwfkzfsRzLRf//DYTUOF qs8Os28DFCa/KvX0e56+c7xOOP9cwgHO3Tl2ri3MAGpxEB5r4PcgmWd4f9zmlmBGE9oNyoyntToB pb/Gi74xj8wc5zCrVpXS1UNVJ8B6Jib+vas1cAtL6RFi0RDtFbUXe9U4wB07Ker1yMtBA6QzfZW2 d0VRyjqv9NL22cjJ4ffotr8ZKbiSVEHbnDRxAgeuMxkkpjQQk/y1S1fk0wDOYNfV0zIkWtVMNBzY Ttmt2pp+/hwLYVAxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxT aWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAy MDIwAgwz1tXFZ7RRpYwmQDswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIKGbFmAa UpmxSRStat3O4M/LPDiuUtF8WyQh1mV25lBeMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJ KoZIhvcNAQkFMQ8XDTIzMDgxNjExMzM1NFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASow CwYJYIZIAWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZI hvcNAQEHMAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQCgf/Ilvsl9HC4s2YdpmISV4eZm zLMmBjvr2SQZg64vnwI2opySyZwz1Rwwht24N3upWb29RWfmKQk2Ubfx3tbGdLaK88spAUMvroXh FYFCYTv3nQ5uw1xBUjLh383G5VHL6RKJ0QSOH7kVXKpnX5ZrQduJnGRouE7SUNZKQeC6NtPfQVjs +ZliAjjrkyK0sWNdzjW2KQYa0mDtmhoRv+mkbTjJPn7D1aBwZCBMACFouxy07QxARNPOSvXlHt4m 8LP2id7GqfZVAb2hxGHdq5RanbqSKryl/vC/kCyCFbnxMZXnfLXvszAuTzDIUeZoj3k1ODbgDm/b OWiADZKGnrxk --000000000000aabf3b060308abe0--