public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: liweihang <liweihang@huawei.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
	"jgg@nvidia.com" <jgg@nvidia.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH for-next 3/6] RDMA/core: Add necessary spaces
Date: Tue, 6 Apr 2021 11:56:54 +0000	[thread overview]
Message-ID: <35a345dba4814345b9a69874c7a61191@huawei.com> (raw)
In-Reply-To: YGwexRBkApaxvnGp@unreal

On 2021/4/6 16:41, Leon Romanovsky wrote:
>> diff --git a/drivers/infiniband/core/iwcm.c b/drivers/infiniband/core/iwcm.c
>> index da8adad..ee5ab1c 100644
>> --- a/drivers/infiniband/core/iwcm.c
>> +++ b/drivers/infiniband/core/iwcm.c
>> @@ -211,7 +211,7 @@ static void free_cm_id(struct iwcm_id_private *cm_id_priv)
>>   */
>>  static int iwcm_deref_id(struct iwcm_id_private *cm_id_priv)
>>  {
>> -	BUG_ON(atomic_read(&cm_id_priv->refcount)==0);
>> +	BUG_ON(atomic_read(&cm_id_priv->refcount) == 0);
> Simply delete this BUG_ON.
> 
> Thanks
> 

Sure, thank you.

Weihang

  reply	other threads:[~2021-04-06 11:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06  8:19 [PATCH for-next 0/6] RDMA/core: Correct some coding-style issues Weihang Li
2021-04-06  8:19 ` [PATCH for-next 1/6] RDMA/core: Print the function name by __func__ instead of an fixed string Weihang Li
2021-04-06  8:19 ` [PATCH for-next 2/6] RDMA/core: Remove the redundant return statements Weihang Li
2021-04-06  8:19 ` [PATCH for-next 3/6] RDMA/core: Add necessary spaces Weihang Li
2021-04-06  8:41   ` Leon Romanovsky
2021-04-06 11:56     ` liweihang [this message]
2021-04-06  8:19 ` [PATCH for-next 4/6] RDMA/core: Remove redundant spaces Weihang Li
2021-04-06  8:43   ` Leon Romanovsky
2021-04-06 12:19     ` liweihang
2021-04-06  8:19 ` [PATCH for-next 5/6] RDMA/core: Correct format of braces Weihang Li
2021-04-06  8:19 ` [PATCH for-next 6/6] RDMA/core: Correct format of block comments Weihang Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35a345dba4814345b9a69874c7a61191@huawei.com \
    --to=liweihang@huawei.com \
    --cc=dledford@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox