Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Allison Henderson <achender@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
	 horms@kernel.org, linux-rdma@vger.kernel.org,
	linux-kselftest@vger.kernel.org,  shuah@kernel.org
Subject: Re: [PATCH net-next v1 0/9] selftests: rds: Add ROCE support to rds selftests
Date: Tue, 12 May 2026 18:54:20 -0700	[thread overview]
Message-ID: <38c21a1067fbdf2f2780b6dfd06d839001943d59.camel@kernel.org> (raw)
In-Reply-To: <20260512184209.0956bcf1@kernel.org>

On Tue, 2026-05-12 at 18:42 -0700, Jakub Kicinski wrote:
> On Mon, 11 May 2026 00:23:07 -0700 Allison Henderson wrote:
> > Currently the rds selftests only tests the tcp transport.  This means
> > most of rds_rdma.ko has no testing coverage.  This series refactors the
> > rds self tests to add an rdma option when running tests.  When used,
> > the test creates a pair of ROCE interfaces to run the payloads through.
> > 
> > Most of this set is refactoring the existing test.py module.  Since most
> > of this code is one long procedure, it is difficult to modularize it
> > without creating a lot of pylint complaints about lengthy functions
> > with too many variables or branches.  The first seven patches address
> > this by breaking down test.py into helper functions.  After we have
> > modularized the send/recv packet logic, we introduce the new ROCE
> > equivalent network configurations, add the new command line flags to
> > build and run the test with rdma support.  
> 
> Looks like there's a handful of ruff and pylint warnings flagged here.

Yes, I noticed those. I will send a v2 with some more pylint/ruff cleanups, and anything else that comes up in the
sashiko reports.


Thanks!
Allison


      reply	other threads:[~2026-05-13  1:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  7:23 [PATCH net-next v1 0/9] selftests: rds: Add ROCE support to rds selftests Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 1/9] selftests: rds: Capitalize ret global in test.py Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 2/9] selftests: rds: Add helper function setup_tcp() " Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 3/9] selftests: rds: Add helper function check_info() " Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 4/9] selftests: rds: Add helper function send_burst() " Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 5/9] selftests: rds: Add helper function recv_burst() " Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 6/9] selftests: rds: Add helper function verify_hashes() " Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 7/9] selftests: rds: Add helper function snd_rcv_packets() " Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 8/9] selftests: rds: Add ROCE support to test.py Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 9/9] selftests: rds: Add ROCE support to run.sh Allison Henderson
2026-05-13  1:42 ` [PATCH net-next v1 0/9] selftests: rds: Add ROCE support to rds selftests Jakub Kicinski
2026-05-13  1:54   ` Allison Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38c21a1067fbdf2f2780b6dfd06d839001943d59.camel@kernel.org \
    --to=achender@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox