Re: Re: Re: [PATCH for-rc] RDMA/vmw_pvrdma: Fix the active_speed and phys_state value

[Adit Ranadive <aditr@vmware.com>]

On 10/29/20 9:16 AM, Adit Ranadive wrote:
> On 10/29/20 4:57 AM, Jason Gunthorpe wrote:
>> On Wed, Oct 28, 2020 at 11:19:45PM +0000, Adit Ranadive wrote:
>>> The PVRDMA device still reports the active_speed in u8.
>>> Lets use the ib_eth_get_speed to report the speed and
>>> width. Unfortunately, phys_state gets stored as msb of
>>> the new u16 active_speed.
>>
>> This explanation is not clear, I have no idea what this is fixing
> 
> It seemed more clear to me in my head, I guess :).
> 
> After commit 376ceb31ff87 changed the active_speed attribute to
> u16, both the active_speed and phys_state attributes in the
> pvrdma_port_attr struct are getting stored in this u16. As a 
> result, these show up as invalid values in ibv_devinfo.
> 
> Our device still gives us back a u8 active_speed so both these
> are getting stored in the u16. This fix I proposed simply gets 
> the active_speed from the netdev while the phys_state still 
> needs to come from the pvrdma device, i.e. the msb the of the
> u16. I also removed some unused functions as a result.
> 
> Alternatively, I could change the u8 active_width and u16 
> active_speed to reserved now that we're getting the active_speed
> and active_width from the ib_get_eth_speed function.
> 

Jason, did you have any comments on this or did you want me
to just send v1 with an updated description?

>>
>> Jason
>>