From: Bob Pearson <rpearsonhpe@gmail.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: zyjzyj2000@nvidia.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next] RDMA/rxe: Remove extra rxe_get(qp) in rxe_rcv_mcast_pkt
Date: Thu, 23 Feb 2023 12:08:44 -0600 [thread overview]
Message-ID: <3921c085-7f05-0116-302c-fe766fd37655@gmail.com> (raw)
In-Reply-To: <Y/VTLrx8ayveJ9/w@nvidia.com>
On 2/21/23 17:26, Jason Gunthorpe wrote:
> On Tue, Feb 21, 2023 at 02:54:29PM -0600, Bob Pearson wrote:
>> The rxe driver implements UD multicast support by cloning an incoming
>> request packet to give one each to the qp's that belong to the multi-
>> cast group. If there are N qp's in the group N-1 clones are created
>> and for each one a reference is taken to the ib device and a reference
>> is taken to the destination qp. This matches the behavior of non
>> multicast packets. The packet itself which already has a reference
>> to the ib device and the qp is given to the last qp.
>>
>> Incorrectly, rxe_rcv_mcast_pkt() takes an additional qp reference
>> which is not needed and will prevent the qp from being destroyed
>> without an error timeout. This patch removes that qp reference.
This was all wrong. The incoming packet had qpn = IB_MULTICAST_QPN
so it did *not* lookup the qp and take a reference.
>>
>> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
>> ---
>> drivers/infiniband/sw/rxe/rxe_recv.c | 1 -
>> 1 file changed, 1 deletion(-)
>
> Needs a fixes line..
>
> Jason
Please withdraw this patch.
Bob
prev parent reply other threads:[~2023-02-23 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 20:54 [PATCH for-next] RDMA/rxe: Remove extra rxe_get(qp) in rxe_rcv_mcast_pkt Bob Pearson
2023-02-21 23:26 ` Jason Gunthorpe
2023-02-23 18:08 ` Bob Pearson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3921c085-7f05-0116-302c-fe766fd37655@gmail.com \
--to=rpearsonhpe@gmail.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox