public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH RFC v2 0/2] libibverbs memory barrier fixes
Date: Fri, 20 May 2016 16:20:14 -0400	[thread overview]
Message-ID: <3ffd3089-ede9-aebf-4781-2e012bc65252@redhat.com> (raw)
In-Reply-To: <20160520200053.6983AE0B9D-/5N3P9jjx0xzbRFIqnYvSA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

On 05/20/2016 03:43 PM, Steve Wise wrote:
> This is v2 of the ARM64 mb* support, plus an additional patch to fail
> compiles if there is no platform implementation of the memory barriers.
> I've included the 2nd patch because I think it is important to not
> assume any default barrier implementation.  Getting it wrong can result
> in data corruption.
> 
> Changes since V1:
> 
> Put the RFC tag back on because I want to retest this series.
> 
> Implemented the ARM64 memory barrier macros from scratch using the AMD
> reference docs.
> 
> Added 2nd patch to fail compiles if no mb* macros exist for the platform.
> 
> Steve Wise (2):
>   libibverbs: add ARM64 memory barrier macros
>   Fail compiles if no platform specific memory barriers exist
> 
>  include/infiniband/arch.h |   15 +++++++++------
>  1 files changed, 9 insertions(+), 6 deletions(-)
> 

Please remember to use --thread=shallow when sending patch emails using
git send-email (which is what I assume you did).

Let me know how the testing comes out.  The patches look fine to me
(thanks for adding the second one, it's the right thing to do).

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

  parent reply	other threads:[~2016-05-20 20:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20 19:43 [PATCH RFC v2 0/2] libibverbs memory barrier fixes Steve Wise
     [not found] ` <20160520200053.6983AE0B9D-/5N3P9jjx0xzbRFIqnYvSA@public.gmane.org>
2016-05-20 20:20   ` Doug Ledford [this message]
     [not found]     ` <3ffd3089-ede9-aebf-4781-2e012bc65252-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-20 20:27       ` Steve Wise
2016-05-22 11:16         ` Noa Osherovich
2016-05-25 14:51       ` Steve Wise
2016-05-25 14:57         ` Doug Ledford
2016-05-30 11:17         ` Noa Osherovich
     [not found]           ` <a10b354c-f9f5-04c8-260d-841273e25b7c-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-05-31 14:16             ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ffd3089-ede9-aebf-4781-2e012bc65252@redhat.com \
    --to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox