From: Jacob Keller <jacob.e.keller@intel.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, Saeed Mahameed <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] net/mlx5: Use PTR_ERR_OR_ZERO() to simplify code
Date: Wed, 23 Aug 2023 12:45:17 -0700 [thread overview]
Message-ID: <414e1ec9-e3a8-d555-3d12-8689a5cc64eb@intel.com> (raw)
In-Reply-To: <20230822062312.3982963-1-ruanjinjie@huawei.com>
On 8/21/2023 11:23 PM, Jinjie Ruan wrote:
> Return PTR_ERR_OR_ZERO() instead of return 0 or PTR_ERR() to
> simplify code.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 8 ++------
> drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c | 10 ++--------
> 2 files changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c
> index 934b0d5ce1b3..777d311d44ef 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c
> @@ -1283,9 +1283,7 @@ static int mlx5e_create_inner_ttc_table(struct mlx5e_flow_steering *fs,
> mlx5e_set_inner_ttc_params(fs, rx_res, &ttc_params);
> fs->inner_ttc = mlx5_create_inner_ttc_table(fs->mdev,
> &ttc_params);
> - if (IS_ERR(fs->inner_ttc))
> - return PTR_ERR(fs->inner_ttc);
> - return 0;
> + return PTR_ERR_OR_ZERO(fs->inner_ttc);
> }
>
> int mlx5e_create_ttc_table(struct mlx5e_flow_steering *fs,
> @@ -1295,9 +1293,7 @@ int mlx5e_create_ttc_table(struct mlx5e_flow_steering *fs,
>
> mlx5e_set_ttc_params(fs, rx_res, &ttc_params, true);
> fs->ttc = mlx5_create_ttc_table(fs->mdev, &ttc_params);
> - if (IS_ERR(fs->ttc))
> - return PTR_ERR(fs->ttc);
> - return 0;
> + return PTR_ERR_OR_ZERO(fs->ttc);
> }
>
> int mlx5e_create_flow_steering(struct mlx5e_flow_steering *fs,
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
> index 7d9bbb494d95..101b3bb90863 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
> @@ -507,10 +507,7 @@ static int mlx5_lag_create_ttc_table(struct mlx5_lag *ldev)
>
> mlx5_lag_set_outer_ttc_params(ldev, &ttc_params);
> port_sel->outer.ttc = mlx5_create_ttc_table(dev, &ttc_params);
> - if (IS_ERR(port_sel->outer.ttc))
> - return PTR_ERR(port_sel->outer.ttc);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(port_sel->outer.ttc);
> }
>
> static int mlx5_lag_create_inner_ttc_table(struct mlx5_lag *ldev)
> @@ -521,10 +518,7 @@ static int mlx5_lag_create_inner_ttc_table(struct mlx5_lag *ldev)
>
> mlx5_lag_set_inner_ttc_params(ldev, &ttc_params);
> port_sel->inner.ttc = mlx5_create_inner_ttc_table(dev, &ttc_params);
> - if (IS_ERR(port_sel->inner.ttc))
> - return PTR_ERR(port_sel->inner.ttc);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(port_sel->inner.ttc);
> }
>
> int mlx5_lag_port_sel_create(struct mlx5_lag *ldev,
next prev parent reply other threads:[~2023-08-23 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 6:23 [PATCH net-next] net/mlx5: Use PTR_ERR_OR_ZERO() to simplify code Jinjie Ruan
2023-08-23 19:45 ` Jacob Keller [this message]
2023-08-25 18:02 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414e1ec9-e3a8-d555-3d12-8689a5cc64eb@intel.com \
--to=jacob.e.keller@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ruanjinjie@huawei.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox