From mboxrd@z Thu Jan 1 00:00:00 1970 From: Logan Gunthorpe Subject: Re: [PATCH 08/12] nvme-pci: clean up SMBSZ bit definitions Date: Thu, 4 Jan 2018 12:08:29 -0700 Message-ID: <4432ed79-e463-e868-64af-0f130dafb261@deltatee.com> References: <20180104190137.7654-1-logang@deltatee.com> <20180104190137.7654-9-logang@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180104190137.7654-9-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 04/01/18 12:01 PM, Logan Gunthorpe wrote: > From: Christoph Hellwig > > Define the bit positions instead of macros using the magic values, > and move the expanded helpers to calculate the size and size unit into > the implementation C file. > > Signed-off-by: Christoph Hellwig Oops, I forgot: Signed-off-by: Logan Gunthorpe