From: Arnd Bergmann <arnd@arndb.de>
To: Leon Romanovsky <leonro@mellanox.com>
Cc: Matan Barak <matanb@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Sagi Grimberg <sagig@mellanox.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Noa Osherovich <noaos@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/mlx5: avoid bogus -Wmaybe-uninitialized warning
Date: Mon, 24 Oct 2016 22:46:26 +0200 [thread overview]
Message-ID: <4613531.FpoFIBnNDo@wuerfel> (raw)
In-Reply-To: <20161024170642.GL25013@leon.nu>
On Monday, October 24, 2016 8:06:42 PM CEST Leon Romanovsky wrote:
>
> Acked-by: Leon Romanovsky <leonro@mellanox.com>
Thanks!
> > drivers/infiniband/hw/mlx5/mr.c | 39 +++++++++++++++++++++------------------
> > 1 file changed, 21 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> > index d4ad672b905b..88d8d292677b 100644
> > --- a/drivers/infiniband/hw/mlx5/mr.c
> > +++ b/drivers/infiniband/hw/mlx5/mr.c
> > @@ -815,29 +815,33 @@ static void prep_umr_unreg_wqe(struct mlx5_ib_dev *dev,
> > umrwr->mkey = key;
> > }
> >
> > -static struct ib_umem *mr_umem_get(struct ib_pd *pd, u64 start, u64 length,
> > - int access_flags, int *npages,
> > - int *page_shift, int *ncont, int *order)
> > +static int mr_umem_get(struct ib_pd *pd, u64 start, u64 length,
> > + int access_flags, struct ib_umem ** umem,
>
> I wonder if checkpatch does differentiate between "struct ib_umem ** umem"
> and "struct ib_umem **umem". According to coding style, the second is preferable.
It was unintended, I'll send a v2 patch in a minute.
Arnd
prev parent reply other threads:[~2016-10-24 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 15:16 [PATCH] IB/mlx5: avoid bogus -Wmaybe-uninitialized warning Arnd Bergmann
2016-10-24 17:06 ` Leon Romanovsky
2016-10-24 20:46 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4613531.FpoFIBnNDo@wuerfel \
--to=arnd@arndb.de \
--cc=bart.vanassche@sandisk.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=noaos@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=sagig@mellanox.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox