Re: [PATCH v4 for-rc] RDMA/rxe: Fix panic when calling kmem_cache_create()

[Bart Van Assche <bvanassche@acm.org>]

On 2020-08-27 07:54, Jason Gunthorpe wrote:
> On Thu, Aug 27, 2020 at 05:29:55PM +0300, Kamal Heib wrote:
>>> Can you send a PR to rdma-core to delete rxe_cfg as well? In
>>> preperation to remove the module parameters
>>>
>>
>> Someone already did that :-)
>>
>> commit 0d2ff0e1502ebc63346bc9ffd37deb3c4fd0dbc9
>> Author: Jason Gunthorpe <jgg@ziepe.ca>
>> Date:   Tue Jan 28 15:53:07 2020 -0400
>>
>>     rxe: Remove rxe_cfg
>>
>>     This is obsoleted by iproute2's 'rdma link add' command.
>>
>>     Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
> 
> Oh! Lets drop the kernel side of this in Jan 2021 then?

I think the person who wants to remove the kernel side of this is responsible
for modifying blktests such that blktests does not break. From the blktests
source code:

                modprobe rdma_rxe || return $?
                (
                        cd /sys/class/net &&
                                for i in *; do
                                        if [ -e "$i" ] && ! has_rdma_rxe "$i"; then
                                                echo "$i" > /sys/module/rdma_rxe/parameters/add ||
                                                        echo "Failed to bind the rdma_rxe driver to $i"
                                        fi
                                done
                )

Thanks,

Bart.