linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org,
	hch-jcswGhMUV9g@public.gmane.org,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v5 1/6] iw_cxgb4: call dev_put() on l2t allocation failure
Date: Thu, 1 Sep 2016 06:43:46 -0700	[thread overview]
Message-ID: <47a029af714aad672bd4a9b0dc39806289e61ae7.1472833420.git.swise@opengridcomputing.com> (raw)
In-Reply-To: <cover.1472833420.git.swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>

Reviewed-by: Sagi Grimberg <sagi-Eyp3ogxVSr5BDLzU/O5InQ@public.gmane.org>
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
---
 drivers/infiniband/hw/cxgb4/cm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index b6a953a..434a7fb 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -2117,8 +2117,10 @@ static int import_ep(struct c4iw_ep *ep, int iptype, __u8 *peer_ip,
 		}
 		ep->l2t = cxgb4_l2t_get(cdev->rdev.lldi.l2t,
 					n, pdev, rt_tos2priority(tos));
-		if (!ep->l2t)
+		if (!ep->l2t) {
+			dev_put(pdev);
 			goto out;
+		}
 		ep->mtu = pdev->mtu;
 		ep->tx_chan = cxgb4_port_chan(pdev);
 		ep->smac_idx = cxgb4_tp_smt_idx(adapter_type,
-- 
2.7.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-09-01 13:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 16:23 [PATCH v5 0/6] nvme-rdma device removal fixes Steve Wise
     [not found] ` <cover.1472833420.git.swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2016-09-01 13:43   ` Steve Wise [this message]
2016-09-01 13:44   ` [PATCH v5 2/6] iw_cxgb4: block module unload until all ep resources are released Steve Wise
2016-09-01 16:12   ` [PATCH v5 3/6] nvme_rdma: keep a ref on the ctrl during delete/flush Steve Wise
2016-09-02 16:01   ` [PATCH v5 4/6] nvme-rdma: destroy nvme queue rdma resources on connect failure Steve Wise
2016-09-02 16:01   ` [PATCH v5 5/6] nvme-rdma: add DELETING queue flag Steve Wise
2016-09-02 16:01   ` [PATCH v5 6/6] nvme-rdma: use ib_client API to detect device removal Steve Wise
2016-09-04  7:01   ` [PATCH v5 0/6] nvme-rdma device removal fixes Sagi Grimberg
     [not found]     ` <89eb2382-9a2f-48d1-c9fd-0c018e07cd9f-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-09-12 14:49       ` Steve Wise
2016-09-12 14:58         ` Sagi Grimberg
     [not found]           ` <f492116d-72ad-0217-9e8f-56e890324c45-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-09-12 15:00             ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47a029af714aad672bd4a9b0dc39806289e61ae7.1472833420.git.swise@opengridcomputing.com \
    --to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).