Re: [PATCH] net/mlx5: Use secs_to_jiffies() instead of msecs_to_jiffies()

[Jacob Keller <jacob.e.keller@intel.com>]

On 2/19/2025 12:49 PM, Thorsten Blum wrote:
> Use secs_to_jiffies() and simplify the code.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

nit: this is a cleanup which should have the net-next prefix applied,
since this doesn't fix any user visible behavior.

Otherwise, seems like an ok change.

> ---
>  drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c
> index 3dbd4efa21a2..19dce1ba512d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c
> @@ -220,7 +220,7 @@ static int hws_bwc_queue_poll(struct mlx5hws_context *ctx,
>  			      bool drain)
>  {
>  	unsigned long timeout = jiffies +
> -				msecs_to_jiffies(MLX5HWS_BWC_POLLING_TIMEOUT * MSEC_PER_SEC);
> +				secs_to_jiffies(MLX5HWS_BWC_POLLING_TIMEOUT);
>  	struct mlx5hws_flow_op_result comp[MLX5HWS_BWC_MATCHER_REHASH_BURST_TH];

This looks like it violates RCT ordering now though.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Thanks,
Jake

>  	u16 burst_th = hws_bwc_get_burst_th(ctx, queue_id);
>  	bool got_comp = *pending_rules >= burst_th;