How to handle illegal multicast addresses in IPoIB?

How to handle illegal multicast addresses in IPoIB?

[Moni Shoua]

Hi,
The problem in short: Illegal multicast addresses can be passed to ib_ipoib which will add them to the queue of multicast addresses it needs to join. From this point on ib_ipoib will get stuck in the attempt to join an illegal multicast group and without a giving a chance for other groups to try.

Recently 2 patches were sent to to deal with this problem. Both of them were rejectedm mainly from technical reasons.
Since I think that it is important to have the problem fixed I want to revive the discussion and resubmit one of them or both, according to the opinions here.

One patch (http://lists.openfabrics.org/pipermail/general/2009-August/061663.html) checks each multicast address for validity before it lets it get into the queue. 

The other patch (http://lists.openfabrics.org/pipermail/general/2009-August/061693.html) queues all addresses it gets but adds fairness to the join attempts.

My questions is: Do we need both patches? If not, which one to choose?

I think that the first patch (check validity) is good enough.

thanks
 MoniS
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: How to handle illegal multicast addresses in IPoIB?

[Or Gerlitz]

Moni Shoua wrote:
> One patch (http://lists.openfabrics.org/pipermail/general/2009-August/061663.html) checks each 
> multicast address for validity before it lets it get into the queue. 

isn't it the below commit which appears in Linus tree?

Or.
> commit 5e47596bee12597824a3b5b21e20f80b61e58a35
> Author: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> Date:   Sat Sep 5 20:23:40 2009 -0700
> 
>     IPoIB: Check multicast address format
> 
>     Check that the format of multicast link addresses is correct before
>     taking them from dev->mc_list to priv->multicast_list.  This way we
>     never try to send a bogus address to the SA, which prevents badness
>     from erronous 'ip maddr addr add', broken bonding drivers, etc.
> 
>     Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
>     Signed-off-by: Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: How to handle illegal multicast addresses in IPoIB?

[Moni Shoua]

Or Gerlitz wrote:
> Moni Shoua wrote:
>> One patch (http://lists.openfabrics.org/pipermail/general/2009-August/061663.html) checks each 
>> multicast address for validity before it lets it get into the queue. 
> 
> isn't it the below commit which appears in Linus tree?
> 
> Or.
>> commit 5e47596bee12597824a3b5b21e20f80b61e58a35
>> Author: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Yes, thanks you...
I must have missed it.

So there is only one question left. Do we also need the other patch?

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: How to handle illegal multicast addresses in IPoIB?

[Jason Gunthorpe]

On Mon, Sep 21, 2009 at 05:39:11PM +0300, Moni Shoua wrote:

> So there is only one question left. Do we also need the other patch?

Yes, we need something like the other patch to handle the case where
the SM is unwilling to create a group for some reason. Right now that
is exactly the same failure mode as an invalid MGID and wrecks ipoib
if it happens.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html