From: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iWCM: Do not call provider reject method with irqs disabled.
Date: Tue, 29 Sep 2009 12:39:09 -0500 [thread overview]
Message-ID: <4AC2463D.9000101@opengridcomputing.com> (raw)
In-Reply-To: <adaocotvhq4.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Roland Dreier wrote:
> Haven't looked closely... could you provide commentatry on why dropping
> the lock is safe here? No chance of racing against something else?
>
> Anyway -ENOCHANGELOG
>
> - R.
>
Sorry Roland. I'll add a changelog and repost.
The reason its ok to release the lock around the provide reject() call:
1) the provider will do nothing with this endpoint until the iwcm either
accepts or rejects.
2) the lock is only released after the iwcm state is changed, so an
errant iwcm user that is destroying -and- rejecting the connection
concurrently will get a failure on one of the calls.
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-09-29 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 19:03 [PATCH] iWCM: Do not call provider reject method with irqs disabled Steve Wise
[not found] ` <20090928190328.26092.69566.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2009-09-29 16:27 ` Roland Dreier
[not found] ` <adaocotvhq4.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-09-29 17:39 ` Steve Wise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC2463D.9000101@opengridcomputing.com \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox