From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vu Pham Subject: Re: [ofa-general][PATCH 1/4] SRP fail-over faster Date: Wed, 14 Oct 2009 12:52:11 -0700 Message-ID: <4AD62BEB.7060504@mellanox.com> References: <4AD3B433.7040803@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier Cc: Linux RDMA list List-Id: linux-rdma@vger.kernel.org Roland Dreier wrote: > One meta comment: when sending a series of 4 patches, please choose a > descriptive subject for each one. We don't want the same headline in > the kernel log for all 4 patches. > > I'll remember next time > > - qp_attr.qp_state = IB_QPS_RESET; > > - ret = ib_modify_qp(target->qp, &qp_attr, IB_QP_STATE); > > - if (ret) > > - goto err; > > - > > - ret = srp_init_qp(target, target->qp); > > - if (ret) > > + old_qp = target->qp; > > + old_cq = target->cq; > > + ret = srp_create_target_ib(target); > > I don't understand why this is any faster? Is creating a new QP really > any different from modifying an old QP to reset state? > It is not; it is needed for patch 2/4 disconnect without wait and it is faster that way -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html