From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH 2/2] rdma/cm: allow user to specify IP to DGID mapping Date: Sun, 25 Oct 2009 13:32:27 +0200 Message-ID: <4AE4374B.6020104@voltaire.com> References: <4ACAF913.3050909@voltaire.com> <15ddcffd0910071523w4f229b14j905ad170ceb8c21f@mail.gmail.com> <9F4DE6A2B4F644698E94F00C4FEEF30A@amr.corp.intel.com> <0A383504E0E54C949DEF84405E3AE92F@amr.corp.intel.com> <15ddcffd0910081633q20d98abfg41a9f4e781e486b1@mail.gmail.com> <859D79BFCA4741F393AABF76BBCA4F7B@amr.corp.intel.com> <4ADD8F5F.3010008@voltaire.com> <9F76F7CD7B9048E8821A1B05CC5FAFE8@amr.corp.intel.com> <4AE07D41.7040300@voltaire.com> <20091022163904.GC26003@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091022163904.GC26003-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Sean Hefty , linux-rdma , Roland Dreier List-Id: linux-rdma@vger.kernel.org Jason Gunthorpe wrote: > So why not have a more general, flexible approach? Isolating ACM from librdmacm by using AF_IB is a good idea, it keeps them seperate and lets ACM and future go where ever. I hope Sean can make it work with the rdma_getddrinfo idea, that would completely seperate ACM and librdmacm Generally speaking, AF_IB/PS_IB sounds okay to me, even though I am not clear what applications are going to use it, maybe some examples please? > Attempting to bake it into AF_INET means that librdmacm, possibly the kernel and maybe even the apps need to be contaminated with ACM specific code, and that just doesn't seem desirable to me. What happens when someone invents BCM or CCM? More mess I don't agree, the only place where librdmacm goes to ACM is to resolve DGID and a route. This can be done with rdma_getdgidinfo & rdma_getrouteinfo if you like (maybe you do the implementation?), or with ACM (later BCM, CCM) plugin used by librdmacm or by calls from librdmacm to ACM. But in any case, the kernel code nor the app will not be contaminated. Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html