public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: QoS in local SA entity
Date: Sun, 08 Nov 2009 08:25:55 +0200	[thread overview]
Message-ID: <4AF66473.2050303@voltaire.com> (raw)
In-Reply-To: <9BF1CEFA7F6F44F5B5641065C4914EB5-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>

Sean Hefty wrote:
> I wasn't trying to limit how the SA could 'distribute' QoS information to the end nodes.  ACM will obtain QoS information from the SA when it joins its
> multicast groups
excellent... still, this is dependent on how the ACM MGIDs are 
constructed, I'll take a look on the code.

> ACM is intended to be a service that's used by the librdmacm to resolve address mappings and routes.  Trying to have ACM use the librdmacm ends up with a circular dependency.  That's the part I'm trying to avoid.

fail-enough, I believe that my suggestion is doable also without 
circular dependency, e.g as you indicated below or with a fairly small 
enhancement of librdmacm, see next


> ACM uses address mappings as defined in an address configuration file (IP ->
> device, port, pkey).  The address file can be created using the provided ib_acme utility, which uses the current system configuration (in an ugly way, but it works).  I think this provides QoS behavior similar to what you're describing
I assume you are referring to an IP local to the system where ACM runs 
on correct? this would work well for applications calling rdma_bind 
and/or rdma_resolve_address while specifying a source address. To 
support also the case of application which do neither of these two, that 
is call rdma_resolve_addr with dest address only, I suggest to enhance 
librdmacm-calling-ACM flow and resolve the source address using route 
lookup from user space, next the librdmacm can issue rdma_bind on behalf 
of this ID and you have the <device, port, pkey> triplet at your hand so 
now the ACM call can be made form librdmacm. Writing this, I realized 
that better(should) be done also for apps _resove_addr with src ip 
specified. This way you have unified flow for the ACM use in librdmacm 
for either of apps A,B,C below

A.1 rdma_bind(src=X)
A.2 rdma_resolve_addr(src=null, dst=Y)

B.1 rdma_resolve_addr(src=null, dst=Y)

C.1 rdma_resolve_addr(src=X, dst=Y)

where librdmacm calling-ACM flow is

L1. compute source address
L2. issue kernel rdma_bind to source address and resolve <device, port, 
pkey>
L3. issue ACM address (DGID) resolution call using (<device, port, 
pkey>, dest-ip)

makes sense? if yes, what's the need in the address configuration file?

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-11-08  6:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05 12:07 QoS in local SA entity Or Gerlitz
     [not found] ` <4AF2C00A.4040808-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2009-11-05 16:40   ` Sean Hefty
     [not found]     ` <9BF1CEFA7F6F44F5B5641065C4914EB5-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2009-11-08  6:25       ` Or Gerlitz [this message]
     [not found]         ` <4AF66473.2050303-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2009-11-09  0:56           ` Jason Gunthorpe
     [not found]             ` <20091109005607.GV1966-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2009-11-09  7:44               ` Or Gerlitz
     [not found]                 ` <4AF7C85F.5000604-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2009-11-09  8:08                   ` Jason Gunthorpe
     [not found]                     ` <20091109080812.GX1966-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2009-11-10  5:51                       ` Or Gerlitz
2009-11-09 18:38           ` Sean Hefty
     [not found]             ` <5C9CD47F123648F0A926E151BF775484-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2009-11-10  5:29               ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF66473.2050303@voltaire.com \
    --to=ogerlitz-smomgflxvozwk0htik3j/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox