public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: frank zago <fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [patch 4/8] cxgb3 - ib_post_recv fixes
Date: Tue, 24 Nov 2009 11:36:43 -0600	[thread overview]
Message-ID: <4B0C19AB.7060107@systemfabricworks.com> (raw)
In-Reply-To: <20091124043323.927819053-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>

Always set ib_post_recv()'s bad_wr. And like the other IB drivers,
return ENOMEM when the queue is full.

Signed-off-by: Frank Zago <fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
Index: linux-2.6.31/drivers/infiniband/hw/cxgb3/iwch_qp.c
===================================================================
--- linux-2.6.31.orig/drivers/infiniband/hw/cxgb3/iwch_qp.c	2009-11-23 
21:18:04.000000000 -0600
+++ linux-2.6.31/drivers/infiniband/hw/cxgb3/iwch_qp.c	2009-11-23 
21:21:40.000000000 -0600
@@ -474,18 +474,19 @@
  	spin_lock_irqsave(&qhp->lock, flag);
  	if (qhp->attr.state > IWCH_QP_STATE_RTS) {
  		spin_unlock_irqrestore(&qhp->lock, flag);
-		return -EINVAL;
+		err = -EINVAL;
+		goto out;
  	}
  	num_wrs = Q_FREECNT(qhp->wq.rq_rptr, qhp->wq.rq_wptr,
  			    qhp->wq.rq_size_log2) - 1;
  	if (!wr) {
  		spin_unlock_irqrestore(&qhp->lock, flag);
-		return -EINVAL;
+		err = -ENOMEM;
+		goto out;
  	}
  	while (wr) {
  		if (wr->num_sge > T3_MAX_SGE) {
  			err = -EINVAL;
-			*bad_wr = wr;
  			break;
  		}
  		idx = Q_PTR2IDX(qhp->wq.wptr, qhp->wq.size_log2);
@@ -497,10 +498,10 @@
  				err = build_zero_stag_recv(qhp, wqe, wr);
  		else
  			err = -ENOMEM;
-		if (err) {
-			*bad_wr = wr;
+
+		if (err)
  			break;
-		}
+
  		build_fw_riwrh((void *) wqe, T3_WR_RCV, T3_COMPLETION_FLAG,
  			       Q_GENBIT(qhp->wq.wptr, qhp->wq.size_log2),
  			       0, sizeof(struct t3_receive_wr) >> 3, T3_SOPEOP);
@@ -514,6 +515,10 @@
  	}
  	spin_unlock_irqrestore(&qhp->lock, flag);
  	ring_doorbell(qhp->wq.doorbell, qhp->wq.qpid);
+
+out:
+	if (err)
+		*bad_wr = wr;
  	return err;
  }


-- 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-11-24 17:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20091124043323.927819053@systemfabricworks.com>
     [not found] ` <20091124043323.927819053-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 17:36   ` [patch 1/8] Ammasso - ib_post_send fix frank zago
     [not found]     ` <4B0C19A1.1050008-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-12-02 17:34       ` Roland Dreier
2009-11-24 17:36   ` [patch 2/8] ehca - ib_post_send fixes Always set ib_post_send()s bad_wr. Do not report success if an error occurred frank zago
2009-11-24 17:36   ` [patch 3/8] cxgb3 - ib_post_send fixes frank zago
2009-11-24 17:36   ` frank zago [this message]
2009-11-24 17:36   ` [patch 5/8] ehca - ib_post_recv fixes Always set ib_post_recv()s bad_wr frank zago
     [not found]     ` <4B0C19AE.6030006-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 23:06       ` Alexander Schmidt
2009-11-24 23:28         ` frank zago
2009-11-24 17:36   ` [patch 7/8] NES - ib_post_send fixes frank zago
     [not found]     ` <4B0C19B1.8030304-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 20:00       ` Tung, Chien Tin
2009-11-24 17:36   ` [patch 6/8] ammasso - ib_post_recv fix frank zago
2009-11-24 17:36   ` [patch 8/8] NES - ib_post_recv fixes frank zago
     [not found]     ` <4B0C19B8.8010807-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 20:00       ` Tung, Chien Tin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0C19AB.7060107@systemfabricworks.com \
    --to=fzago-klaocwyjdxkshymvu7je4pqqe7ycjdx5@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox