public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: frank zago <fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
To: Alexander Schmidt
	<alexs-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Stefan Roscher
	<stefan.roscher-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
	Hoang-Nam Nguyen
	<HNGUYEN-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
	Joachim Fenkes <fenkes-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
	Christoph Raisch <raisch-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Subject: Re: [patch 5/8] ehca - ib_post_recv fixes Always set ib_post_recv()s bad_wr.
Date: Tue, 24 Nov 2009 17:28:51 -0600	[thread overview]
Message-ID: <4B0C6C33.2040609@systemfabricworks.com> (raw)
In-Reply-To: <20091124180621.0df9150b@alex-laptop>

Alexander Schmidt wrote:
> On Tue, 24 Nov 2009 11:36:46 -0600
> frank zago <fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org> wrote:
>
> Hi Frank,
>
>   
>> Signed-off-by: Frank Zago <fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
>> Index: linux-2.6.31/drivers/infiniband/hw/ehca/ehca_reqs.c
>> ===================================================================
>> --- linux-2.6.31.orig/drivers/infiniband/hw/ehca/ehca_reqs.c	2009-11-23 
>> 21:23:08.000000000 -0600
>> +++ linux-2.6.31/drivers/infiniband/hw/ehca/ehca_reqs.c	2009-11-23 
>> 21:25:48.000000000 -0600
>> @@ -519,7 +519,7 @@
>>   	if (unlikely(!HAS_RQ(my_qp))) {
>>   		ehca_err(dev, "QP has no RQ  ehca_qp=%p qp_num=%x ext_type=%d",
>>   			 my_qp, my_qp->real_qp_num, my_qp->ext_type);
>> -		return -ENODEV;
>> +		ret = -ENODEV;
>>     
>
> aren't you missing a goto statement here?
>   

Indeed. I'll resend a patch.

Frank.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-11-24 23:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20091124043323.927819053@systemfabricworks.com>
     [not found] ` <20091124043323.927819053-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 17:36   ` [patch 1/8] Ammasso - ib_post_send fix frank zago
     [not found]     ` <4B0C19A1.1050008-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-12-02 17:34       ` Roland Dreier
2009-11-24 17:36   ` [patch 2/8] ehca - ib_post_send fixes Always set ib_post_send()s bad_wr. Do not report success if an error occurred frank zago
2009-11-24 17:36   ` [patch 3/8] cxgb3 - ib_post_send fixes frank zago
2009-11-24 17:36   ` [patch 4/8] cxgb3 - ib_post_recv fixes frank zago
2009-11-24 17:36   ` [patch 5/8] ehca - ib_post_recv fixes Always set ib_post_recv()s bad_wr frank zago
     [not found]     ` <4B0C19AE.6030006-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 23:06       ` Alexander Schmidt
2009-11-24 23:28         ` frank zago [this message]
2009-11-24 17:36   ` [patch 7/8] NES - ib_post_send fixes frank zago
     [not found]     ` <4B0C19B1.8030304-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 20:00       ` Tung, Chien Tin
2009-11-24 17:36   ` [patch 6/8] ammasso - ib_post_recv fix frank zago
2009-11-24 17:36   ` [patch 8/8] NES - ib_post_recv fixes frank zago
     [not found]     ` <4B0C19B8.8010807-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 20:00       ` Tung, Chien Tin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0C6C33.2040609@systemfabricworks.com \
    --to=fzago-klaocwyjdxkshymvu7je4pqqe7ycjdx5@public.gmane.org \
    --cc=HNGUYEN-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=alexs-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=fenkes-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=raisch-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    --cc=stefan.roscher-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox