Re: [patch 5/8] ehca - ib_post_recv fixes Always set ib_post_recv()s bad_wr.

frank zago
2009-11-24T23:28:51Z

Alexander Schmidt wrote:
> On Tue, 24 Nov 2009 11:36:46 -0600
> frank zago <fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org> wrote:
>
> Hi Frank,
>
>
>> Signed-off-by: Frank Zago <fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
>> Index: linux-2.6.31/drivers/infiniband/hw/ehca/ehca_reqs.c
>> ===================================================================
>> --- linux-2.6.31.orig/drivers/infiniband/hw/ehca/ehca_reqs.c 2009-11-23
>> 21:23:08.000000000 -0600
>> +++ linux-2.6.31/drivers/infiniband/hw/ehca/ehca_reqs.c 2009-11-23
>> 21:25:48.000000000 -0600
>> @@ -519,7 +519,7 @@
>> if (unlikely(!HAS_RQ(my_qp))) {
>> ehca_err(dev, "QP has no RQ ehca_qp=%p qp_num=%x ext_type=%d",
>> my_qp, my_qp->real_qp_num, my_qp->ext_type);
>> - return -ENODEV;
>> + ret = -ENODEV;
>>
>
> aren't you missing a goto statement here?
>

Indeed. I'll resend a patch.

Frank.