From: Yevgeny Kliteynik <kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Cc: Linux RDMA <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH v2] opensm/osm_mcast_mgr.c: fix osm_mcast_mgr_compute_max_hops for managed switch
Date: Wed, 23 Dec 2009 16:44:12 +0200 [thread overview]
Message-ID: <4B322CBC.1070805@dev.mellanox.co.il> (raw)
If a certain mcast group has only one member, and this
member is a switch, OSM fails to select this switch
when trying to create spanning tree for this mcast group:
ERR 0A08: Unable to locate a suitable switch for group 0xC000
ERR 0A17: Unable to create spanning tree (IB_ERROR) for mlid 0xc000
Signed-off-by: Yevgeny Kliteynik <kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
---
V2: no need to handle the case with no
members in mcast group, it is already
handled by the caller function.
opensm/opensm/osm_mcast_mgr.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/opensm/opensm/osm_mcast_mgr.c b/opensm/opensm/osm_mcast_mgr.c
index 697fb58..6bcbec4 100644
--- a/opensm/opensm/osm_mcast_mgr.c
+++ b/opensm/opensm/osm_mcast_mgr.c
@@ -215,11 +215,9 @@ static float osm_mcast_mgr_compute_max_hops(osm_sm_t * sm, cl_qlist_t * l,
max_hops = hops;
}
- if (max_hops == 0)
- /*
- We should be here if there aren't any ports in the group.
- */
- max_hops = 10001; /* see later - we use it to realize no hops */
+ /* Note that at this point we might get (max_hops == 0),
+ which means that there's only one member in the mcast
+ group, and it's the current switch */
OSM_LOG_EXIT(sm->p_log);
return (float)max_hops;
--
1.5.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2009-12-23 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 14:44 Yevgeny Kliteynik [this message]
[not found] ` <4B322CBC.1070805-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2009-12-24 14:26 ` [PATCH v2] opensm/osm_mcast_mgr.c: fix osm_mcast_mgr_compute_max_hops for managed switch Sasha Khapyorsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B322CBC.1070805@dev.mellanox.co.il \
--to=kliteyn-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox