* clarification on the mlx4 CQE structure
@ 2010-01-19 12:19 Or Gerlitz
[not found] ` <Pine.LNX.4.64.1001191416160.22919-aDiYczhfhVLdX2U7gxhm1tBPR1lH4CV8@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Or Gerlitz @ 2010-01-19 12:19 UTC (permalink / raw)
To: Yevgeny Petrilin; +Cc: linux-rdma
Hi Yevgeny, looking on commit f780a9f "mlx4_core: Add ethernet fields
to CQE struct" I see the following two changes:
@@ -692,14 +692,13 @@ repoll:
- wc->sl = cqe->sl >> 4;
+ wc->sl = be16_to_cpu(cqe->sl_vid >> 12);
I wasn't sure if/why a conversion from network order to host order is
neeed here, can you clarify that?
Or.
@@ -39,17 +39,18 @@
struct mlx4_cqe {
- __be32 my_qpn;
+ __be32 vlan_my_qpn;
- u8 sl;
- u8 reserved1;
+ __be16 sl_vid;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <Pine.LNX.4.64.1001191416160.22919-aDiYczhfhVLdX2U7gxhm1tBPR1lH4CV8@public.gmane.org>]
* RE: clarification on the mlx4 CQE structure [not found] ` <Pine.LNX.4.64.1001191416160.22919-aDiYczhfhVLdX2U7gxhm1tBPR1lH4CV8@public.gmane.org> @ 2010-01-19 13:03 ` Yevgeny Petrilin [not found] ` <2ED289D4E09FBD4D92D911E869B97FDD02783427-ia22CT07NJfiMCgWhms8HQC/G2K4zDHf@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Yevgeny Petrilin @ 2010-01-19 13:03 UTC (permalink / raw) To: Or Gerlitz; +Cc: linux-rdma > @@ -692,14 +692,13 @@ repoll: > - wc->sl = cqe->sl >> 4; > + wc->sl = be16_to_cpu(cqe->sl_vid >> 12); > > I wasn't sure if/why a conversion from network order to host order is neeed here, can you clarify that? This commit has an endianess bug, that was fixed in commit f781a22f. The cqe->sl_vid field is a be16, so we needed to convert the sl value to host order. Before the commit this field was two u8 fields, so no conversion was needed. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <2ED289D4E09FBD4D92D911E869B97FDD02783427-ia22CT07NJfiMCgWhms8HQC/G2K4zDHf@public.gmane.org>]
* Re: clarification on the mlx4 CQE structure [not found] ` <2ED289D4E09FBD4D92D911E869B97FDD02783427-ia22CT07NJfiMCgWhms8HQC/G2K4zDHf@public.gmane.org> @ 2010-01-19 14:08 ` Or Gerlitz 0 siblings, 0 replies; 3+ messages in thread From: Or Gerlitz @ 2010-01-19 14:08 UTC (permalink / raw) To: Yevgeny Petrilin; +Cc: linux-rdma Yevgeny Petrilin wrote: > This commit has an endianess bug, that was fixed in commit f781a22f. > The cqe->sl_vid field is a be16, so we needed to convert the sl value to > host order. Before the commit this field was two u8 fields, so no conversion was needed okay, got it, thanks Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-19 14:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-19 12:19 clarification on the mlx4 CQE structure Or Gerlitz
[not found] ` <Pine.LNX.4.64.1001191416160.22919-aDiYczhfhVLdX2U7gxhm1tBPR1lH4CV8@public.gmane.org>
2010-01-19 13:03 ` Yevgeny Petrilin
[not found] ` <2ED289D4E09FBD4D92D911E869B97FDD02783427-ia22CT07NJfiMCgWhms8HQC/G2K4zDHf@public.gmane.org>
2010-01-19 14:08 ` Or Gerlitz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox