[PATCH] libibverbs: Force line-buffering in ibv_asyncwatch

[PATCH] libibverbs: Force line-buffering in ibv_asyncwatch

[Håkon Bugge]

ibv_asyncwatch defaults to block-buffering when stdout is redirected to a file or pipe. This fix makes it more usable in scripted environments.

Signed-off-by: Hakon Bugge <Haakon.Bugge-xsfywfwIY+M@public.gmane.org>
---
diff --git a/examples/asyncwatch.c b/examples/asyncwatch.c
index e56b4dc..f9fe6ff 100644
--- a/examples/asyncwatch.c
+++ b/examples/asyncwatch.c
@@ -98,6 +98,9 @@ int main(int argc, char *argv[])
                return 1;
        }
 
+       /* Force line-buffering if stdout is redirected */
+       setlinebuf(stdout);
+
        printf("%s: async event FD %d\n",
               ibv_get_device_name(*dev_list), context->async_fd);

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libibverbs: Force line-buffering in ibv_asyncwatch

[Bart Van Assche]

On Thu, Jan 21, 2010 at 2:40 PM, Håkon Bugge <Haakon.Bugge-xsfywfwIY+M@public.gmane.org> wrote:
> ibv_asyncwatch defaults to block-buffering when stdout is redirected to a file or pipe. This fix makes it more usable in scripted environments.
>
> Signed-off-by: Hakon Bugge <Haakon.Bugge-xsfywfwIY+M@public.gmane.org>
> ---
> diff --git a/examples/asyncwatch.c b/examples/asyncwatch.c
> index e56b4dc..f9fe6ff 100644
> --- a/examples/asyncwatch.c
> +++ b/examples/asyncwatch.c
> @@ -98,6 +98,9 @@ int main(int argc, char *argv[])
>                return 1;
>        }
>
> +       /* Force line-buffering if stdout is redirected */
> +       setlinebuf(stdout);
> +
>        printf("%s: async event FD %d\n",
>               ibv_get_device_name(*dev_list), context->async_fd);

It might be a good idea to replace setlinebuf() by setvbuf().
setlinebuf() is a BSD function while setvbuf is POSIX (see also
http://opengroup.org/onlinepubs/009695399/functions/setvbuf.html).

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libibverbs: Force line-buffering in ibv_asyncwatch

[Håkon Bugge]

I guess it depends. ibverbs has other non-POSIX compliant libc functions - so I am not sure there is a POSIX policy enforcement.

If I understand correctly, the charter of OFED is to produce a Linux distribution (and also a Windows distro).

setlinebuf() is pretty intuitive to understand, compared to setvbuf().

-h


On Jan 21, 2010, at 15:18 , Bart Van Assche wrote:

> On Thu, Jan 21, 2010 at 2:40 PM, Håkon Bugge <Haakon.Bugge-xsfywfwIY+M@public.gmane.org> wrote:
>> ibv_asyncwatch defaults to block-buffering when stdout is redirected to a file or pipe. This fix makes it more usable in scripted environments.
>> 
>> Signed-off-by: Hakon Bugge <Haakon.Bugge-xsfywfwIY+M@public.gmane.org>
>> ---
>> diff --git a/examples/asyncwatch.c b/examples/asyncwatch.c
>> index e56b4dc..f9fe6ff 100644
>> --- a/examples/asyncwatch.c
>> +++ b/examples/asyncwatch.c
>> @@ -98,6 +98,9 @@ int main(int argc, char *argv[])
>>                return 1;
>>        }
>> 
>> +       /* Force line-buffering if stdout is redirected */
>> +       setlinebuf(stdout);
>> +
>>        printf("%s: async event FD %d\n",
>>               ibv_get_device_name(*dev_list), context->async_fd);
> 
> It might be a good idea to replace setlinebuf() by setvbuf().
> setlinebuf() is a BSD function while setvbuf is POSIX (see also
> http://opengroup.org/onlinepubs/009695399/functions/setvbuf.html).
> 
> Bart.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Håkon Bugge
Haakon.bugge-U0mLk4xYmo8@public.gmane.org
+47 924 84 514



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libibverbs: Force line-buffering in ibv_asyncwatch

[Roland Dreier]

 > setlinebuf() is pretty intuitive to understand, compared to setvbuf().

I finally applied this; however in the end I decided to do

	setvbuf(stdout, NULL, _IOLBF, 0);

instead of setlinebuf(), since in the past I've prefered more pedantic
stuff (eg posix_memalign instead of memalign) to the older simpler
traditional functions.  Kind of a trivial issue either way anyway.
-- 
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libibverbs: Force line-buffering in ibv_asyncwatch

[Håkon Bugge]

On Jun 2, 2010, at 19:05 , Roland Dreier wrote:

>> setlinebuf() is pretty intuitive to understand, compared to setvbuf().
> 
> I finally applied this; however in the end I decided to do
> 
> 	setvbuf(stdout, NULL, _IOLBF, 0);
> 
> instead of setlinebuf(), since in the past I've prefered more pedantic
> stuff (eg posix_memalign instead of memalign) to the older simpler
> traditional functions.  Kind of a trivial issue either way anyway.


Agree. Thanks anyway.


Håkon

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libibverbs: Force line-buffering in ibv_asyncwatch

[Or Gerlitz]

Håkon Bugge wrote:
> I used the information at www.openfabrics.org/git/?p=ofed_1_2_5/libibverbs.git;a=summary 
> which states the "owner" to be Vlad. May be that confused me. I'll send a copy to Roland

Roland's user space git trees are all hosted @ kernel.org 
the libibverbs one is git://git.kernel.org/pub/scm/libs/infiniband/libibverbs.git
you can find there the libmlx4 and libmthca ones as well.

Vlad - is there a way to prevent such confusion in the future, maybe put a clear comment
in the header of the ofa git page?

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libibverbs: Force line-buffering in ibv_asyncwatch

[Vladimir Sokolovsky]

Or Gerlitz wrote:
> Håkon Bugge wrote:
>> I used the information at www.openfabrics.org/git/?p=ofed_1_2_5/libibverbs.git;a=summary 
>> which states the "owner" to be Vlad. May be that confused me. I'll send a copy to Roland
> 
> Roland's user space git trees are all hosted @ kernel.org 
> the libibverbs one is git://git.kernel.org/pub/scm/libs/infiniband/libibverbs.git
> you can find there the libmlx4 and libmthca ones as well.
> 
> Vlad - is there a way to prevent such confusion in the future, maybe put a clear comment
> in the header of the ofa git page?
> 
> Or.
> --

I'll update comments for the OFED's git trees.

Regards,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html