ibutils license problems + a few other minor issues

ibutils license problems + a few other minor issues

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]

The ibutils tarball as found for download on the openfabrics web site
has some licensing issues that need resolved ASAP.  The tarball in its
current form is probably illegal to distribute until the items are
fixed.  So, here's what popped up in review (done by Jay Fenlason):

The COPYING files sprinkled around in the tarball are not consistent.
Some of them contain a copy of the GPLv2, some of them contain a
statement that the package is licensed under either GPLv2 in the file
COPYING or the OFA BSD license included here in.  Of course, it doesn't
work to reference a COPYING file from within the COPYING file you are
referencing and say it has the information you aren't including here.  I
would suggest that the proper place for the statement of GPLv2 or BSD is
in possibly a LICENSE file with the COPYING file being the GPLv2 as
stated.  It also seems redundant to have multiple COPYING files and
possibly also multiple LICENSE files in a single tarball, so cleanup of
unnecessary files seems in order here.

There are a number of files who have headers that indicate they are
*not* under either GPLv2 or BSD.

ibdm/replace/regex.[ch] are LGPLv2+, so need a LGPLv2+ COPYING somewhere
ibdm/replace/{memset.c,realloc.c,malloc.c} are GPLv2+ versus GPLv2

ibdm/src/fabric_sim.cpp claims to be confidential and proprietary! It
refers to LICENSE.txt for t&c. There is no LICENSE.txt under ibdm/.
There is one under ibmtsim/utils/ though.

ibmgtsim/config/{missing,config.sub,ltmain.sh,depcomp,config.guess} is
GPLv2+
ibmgtsim/config/install-sh is X license

ibmgtsim/utils/{,un}install.sh is GPLv2+

There are also a few other minor issues with the tarball as it builds:

/usr/bin/ibnlparse has no man page

/usr/share/man/man1/ibdm-ibnl-file.1.gz
/usr/share/man/man1/ibdm-topo-file.1.gz
Are in man1, but have no corresponding executables. Perhaps
they should be in a different man section?

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: CFBFF194
	      http://people.redhat.com/dledford

Infiniband specific RPMs available at
	      http://people.redhat.com/dledford/Infiniband


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: ibutils license problems + a few other minor issues

[Tziporet Koren]

On 2/11/2010 7:11 PM, Doug Ledford wrote:
> The ibutils tarball as found for download on the openfabrics web site
> has some licensing issues that need resolved ASAP.  The tarball in its
> current form is probably illegal to distribute until the items are
> fixed.  So, here's what popped up in review (done by Jay Fenlason):
>
> The COPYING files sprinkled around in the tarball are not consistent.
> Some of them contain a copy of the GPLv2, some of them contain a
> statement that the package is licensed under either GPLv2 in the file
> COPYING or the OFA BSD license included here in.  Of course, it doesn't
> work to reference a COPYING file from within the COPYING file you are
> referencing and say it has the information you aren't including here.  I
> would suggest that the proper place for the statement of GPLv2 or BSD is
> in possibly a LICENSE file with the COPYING file being the GPLv2 as
> stated.  It also seems redundant to have multiple COPYING files and
> possibly also multiple LICENSE files in a single tarball, so cleanup of
> unnecessary files seems in order here.
>    

Hi Doug
Thanks for providing the info (I  guess it was in this way from the 
first days we submitted the code to OFA)
Yevgeny will fix this soon

Tziporet
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ibutils license problems + a few other minor issues

[Yevgeny Kliteynik]

Doug,

Thanks for reviewing this.
All the licensing issues have been fixed. See below.

On 11/Feb/10 19:11, Doug Ledford wrote:
> The ibutils tarball as found for download on the openfabrics web site
> has some licensing issues that need resolved ASAP.  The tarball in its
> current form is probably illegal to distribute until the items are
> fixed.  So, here's what popped up in review (done by Jay Fenlason):
>
> The COPYING files sprinkled around in the tarball are not consistent.
> Some of them contain a copy of the GPLv2, some of them contain a
> statement that the package is licensed under either GPLv2 in the file
> COPYING or the OFA BSD license included here in.

Fixed - it's consistent now

> Of course, it doesn't
> work to reference a COPYING file from within the COPYING file you are
> referencing and say it has the information you aren't including here.  I
> would suggest that the proper place for the statement of GPLv2 or BSD is
> in possibly a LICENSE file with the COPYING file being the GPLv2 as
> stated.  It also seems redundant to have multiple COPYING files and
> possibly also multiple LICENSE files in a single tarball, so cleanup of
> unnecessary files seems in order here.

Fixed - there is one COPYING file at the root of the tree, and all
the (c) headers are referencing to this COPYING file.

> There are a number of files who have headers that indicate they are
> *not* under either GPLv2 or BSD.
>
> ibdm/replace/regex.[ch] are LGPLv2+, so need a LGPLv2+ COPYING somewhere

I don't see LGPL in these files, only GPL. It says "GNU *Library*
General Public License", so this could be the reason for confusion.

> ibdm/replace/{memset.c,realloc.c,malloc.c} are GPLv2+ versus GPLv2

So basically, we have the whole ibdm/replace/ directory under
GPLv2+ license. I described it in the COPYING at the tree root.

> ibdm/src/fabric_sim.cpp claims to be confidential and proprietary! It
> refers to LICENSE.txt for t&c. There is no LICENSE.txt under ibdm/.
> There is one under ibmtsim/utils/ though.

Fixed - they are all GPLv2 or BSD, and they are all referencing to
the same COPYING file.
  
> ibmgtsim/config/{missing,config.sub,ltmain.sh,depcomp,config.guess}
> is GPLv2+
> ibmgtsim/config/install-sh is X license
>
> ibmgtsim/utils/{,un}install.sh is GPLv2+

These files are generated by things like autotools or m4.
They are not part of the git tree, but they do exist in the
tarball, because tarball is created after autogen.sh execution.

-- Yevgeny
  
> There are also a few other minor issues with the tarball as it builds:
>
> /usr/bin/ibnlparse has no man page
>
> /usr/share/man/man1/ibdm-ibnl-file.1.gz
> /usr/share/man/man1/ibdm-topo-file.1.gz
> Are in man1, but have no corresponding executables. Perhaps
> they should be in a different man section?
>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html