From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH 1/2] ib/ipoib: allow disabling/enabling TSO through ethtool Date: Thu, 04 Mar 2010 17:13:54 +0200 Message-ID: <4B8FCE32.3090808@Voltaire.com> References: <20100304134018.GA17107@mtldesk030.lab.mtl.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100304134018.GA17107-8YAHvHwT2UEvbXDkjdHOrw/a8Rv0c6iv@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eli Cohen Cc: Roland Dreier , linux-rdma List-Id: linux-rdma@vger.kernel.org Eli Cohen wrote: > I believe dev->features should be protected by rtnl lock. NAK. ethtool issues the SIOCETHTOOL ioctl which goes to net/core/dev.c :: dev_ioctl who in turn wraps the call to dev_ethtool with rtnl_lock/unlock, see below. I have also verified this in practice, that is rtnl_trylock() always fails if called from ipoib ethtool code Or. > case SIOCETHTOOL: > dev_load(net, ifr.ifr_name); > rtnl_lock(); > ret = dev_ethtool(net, &ifr); > rtnl_unlock(); -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html