Re: [PATCH,RFC] nfsd: Make INET6 transport creation failure an informational message

[Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>]

Looks good.


Tom Tucker wrote:
> If this looks right to everyone, I'll post this to linux-nfs.
>
> Tom
>
> nfsd: Make INET6 transport creation failure an informational message
>
> The write_ports code will fail both the IENT4 and INET6 transport 
> creation if
> the transport returns an error when PF_INET6 is specified. Some 
> transports
> that do not support INET6 return an error other than EAFNOSUPPORT. We 
> should
> allow communication on INET4 even if INET6 is not yet supported or fails
> for some reason.
>
> Signed-off-by: Tom Tucker <tom-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> ---
>
> fs/nfsd/nfsctl.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 0f0e77f..019a89e 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -1008,8 +1008,10 @@ static ssize_t __write_ports_addxprt(char *buf)
>
>     err = svc_create_xprt(nfsd_serv, transport,
>                 PF_INET6, port, SVC_SOCK_ANONYMOUS);
> -    if (err < 0 && err != -EAFNOSUPPORT)
> -        goto out_close;
> +    if (err < 0)
> +        dprintk("nfsd: Error creating PF_INET6 listener for transport 
> '%s'\n",
> +             transport);
> +
>     return 0;
> out_close:
>     xprt = svc_find_xprt(nfsd_serv, transport, PF_INET, port);

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html