Re: [PATCH v2 13/51] IB/qib: Add qib_driver.c

Roland Dreier
2010-03-31T23:20:22Z

> +unsigned qib_debug;
> +module_param_named(debug, qib_debug, uint, S_IWUSR | S_IRUGO);
> +MODULE_PARM_DESC(debug, "mask for debug prints");

Did you look at using trace events for this stuff? That gives you
extremely low overhead when tracing is turned off (dynamic patching to
NOP out the tracing when it's disabled) and also very fine-grained (per
trace site) control over what gets printed; plus you get dumping of the
trace buffer on crash, etc.

- R.
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to: