Re: [PATCH v2 38/51] IB/qib: Add qib_sysfs.c

Ralph Campbell
2010-04-12T17:21:31Z

On Fri, 2010-04-09 at 17:27 -0700, Jason Gunthorpe wrote:
> On Fri, Apr 09, 2010 at 05:13:24PM -0700, Ralph Campbell wrote:
>
> > For the QSFP data, I hope I can leave it as is since it is
> > related to the link state that the other files contain.
> > It is a read-only file so no issue with trying to set a value.
>
> There was some flack for other stuff like this a while back.
>
> IMHO, it would be appropriate to have a hex dump of the entire QFSP
> EEPROM and leave parsing to userspace, or put the parsed version in
> debugfs..
>
> Jason

OK. I will move it to our file system which is used
to export binary data.