Re: [PATCH v2 13/51] IB/qib: Add qib_driver.c

Roland Dreier
2010-03-31T23:23:33Z

> +DEFINE_MUTEX(qib_mutex); /* general driver use */

Rather than having this ill-defined mutex that I think is going to make
it hard to understand the locking and get the lock ordering right, would
it be better to have well-defined locking rules? AFAICT this mutex is
used in only two places, qib_diag.c and qib_file_op.c. Are those two
uses protecting the same thing? Or could we have two static mutexes,
one in each file, that protects what each file needs protected?
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to: