Re: [PATCH v2 12/51] IB/qib: Add qib_dma.c

Roland Dreier
2010-03-31T23:18:20Z

> +struct ib_dma_mapping_ops qib_dma_mapping_ops = {
> + qib_mapping_error,
> + qib_dma_map_single,
> + qib_dma_unmap_single,
> + qib_dma_map_page,
> + qib_dma_unmap_page,
> + qib_map_sg,
> + qib_unmap_sg,
> + qib_sg_dma_address,
> + qib_sg_dma_len,
> + qib_sync_single_for_cpu,
> + qib_sync_single_for_device,
> + qib_dma_alloc_coherent,
> + qib_dma_free_coherent
> +};

I think it would be better to use designated initializers (".xxx = yyy,")
here to avoid problems if this struct ever changes layout.
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to: