Re: [PATCH v2 38/51] IB/qib: Add qib_sysfs.c

Ira Weiny
2010-04-08T22:12:34Z

On Thu, 08 Apr 2010 14:33:59 -0700
Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> wrote:

> > This was for debugging and clearly could use a better method.
> > Some stats are definitely useful and having files per value
> > would make scripting easier too.
> > I could add /sys/class/infiniband/qib0/ports/1/diag_counters/*
> >
> > One other place that has multiple values is dumping the QSFP
> > data from the IB cable.
>
> You can stick debugging data under debugfs. Or just kill it for now and
> figure out how to add it back later.

I for one would rather not see this die. We have debugged some critical
issues using this data. The sysfs entries above are what Mellanox uses.
Should those also be changed?

Ira

> --
> Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
> http://*www.*cisco.com/web/about/doing_business/legal/cri/index.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://*vger.kernel.org/majordomo-info.html
>

--
Ira Weiny
Math Programmer/Computer Scientist
Lawrence Livermore National Lab
925-423-8008
weiny2-i2BcT+NCU+M@public.gmane.org