Re: [PATCH v2 38/51] IB/qib: Add qib_sysfs.c

Ralph Campbell
2010-04-10T00:13:24Z

On Thu, 2010-04-08 at 14:33 -0700, Roland Dreier wrote:
> > This was for debugging and clearly could use a better method.
> > Some stats are definitely useful and having files per value
> > would make scripting easier too.
> > I could add /sys/class/infiniband/qib0/ports/1/diag_counters/*
> >
> > One other place that has multiple values is dumping the QSFP
> > data from the IB cable.
>
> You can stick debugging data under debugfs. Or just kill it for now and
> figure out how to add it back later.

OK. I replaced the /sys/class/infiniband/qib0/stats file with

% ls /sys/class/infiniband/qib0/ports/1/diag_counters/
dmawait pkt_drops rc_dupreq rc_seqnak rnr_naks
loop_pkts rc_acks rc_qacks rc_timeouts seq_naks
other_naks rc_delayed_comp rc_resends rdma_seq unaligned

These are all simple counter values.

For the QSFP data, I hope I can leave it as is since it is
related to the link state that the other files contain.
It is a read-only file so no issue with trying to set a value.