Re: [PATCH] opensm/osm_sa_path_record.c: livelock in pr_rcv_get_path_parms

Sasha Khapyorsky
2010-04-21T10:16:42Z

On 20:32 Mon 19 Apr , Line Holen wrote:
> >> @@ -69,6 +70,9 @@
> >> #include <opensm/osm_prefix_route.h>
> >> #include <opensm/osm_ucast_lash.h>
> >>
> >> +
> >> +#define MAX_HOPS 128
> >
> > IB spec defines maximal number of hops for a fabric which is 64. Would
> > it be netter to use this value here?
> >
> > Sasha
>
> The value of 128 was chosen as 2x max DR path allowing the SM to be in
> the middle of a fabric. But I have no problem lowering to 64.

The path in this calculation is between ports and SM is not part of the
game.

For me it seems that 64 would be better number. Hypothetically it could
be even unrelated to LFTs transition issue - when path exceeds 64 hops
SA can return NOT FOUND just well.

Sasha