RE: [PATCH] RDMA/ucma: Copy iWARP route information.

Sean Hefty
2010-05-10T17:36:17Z

>For iWARP rdma_cm ids, the "route" information is the L2 src and
>next hop addresses.
>
>Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
>---
>
> drivers/infiniband/core/ucma.c | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
>index ac7edc2..0498383 100644
>--- a/drivers/infiniband/core/ucma.c
>+++ b/drivers/infiniband/core/ucma.c
>@@ -583,6 +583,16 @@ static void ucma_copy_ib_route(struct
>rdma_ucm_query_route_resp *resp,
> }
> }
>
>+static void ucma_copy_iw_route(struct rdma_ucm_query_route_resp *resp,
>+ struct rdma_route *route)
>+{
>+ struct rdma_dev_addr *dev_addr;
>+
>+ dev_addr = &route->addr.dev_addr;
>+ rdma_addr_get_dgid(dev_addr, (union ib_gid *) &resp->ib_route[0].dgid);
>+ rdma_addr_get_sgid(dev_addr, (union ib_gid *) &resp->ib_route[0].sgid);

This looks good for the current code.

For 2.6.35/36, I've submitted changes to the query operation to support AF_IB,
essentially breaking the query_route call into query_addr, query_path, and
query_gid. I'm guessing that this functionality should be part of the query_gid
call. I'll adjust those patches, but if you get a chance to review the query
changes, I'd appreciate it.

- Sean