Re: [PATCH] opensm: fixing compilation issues in some header files

[Yevgeny Kliteynik <kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On 01-Jun-10 10:22 PM, Sasha Khapyorsky wrote:
> Hi Yevgeny,
>
> On 14:58 Tue 01 Jun     , Yevgeny Kliteynik wrote:
>>
>> On 24-Mar-10 5:50 PM, Yevgeny Kliteynik wrote:
>>> All the compilation issues refer to implicit casting
>>> from "void*" to "some_struct_t*"
>>
>> This was detected when compiling a code that includes these
>> headers with g++ compiler. The headers should be able to compile
>> by g++ (they have 'extern "C"').
>
> Well let's apply the patch since we have 'extern "C"'.
>
> But this raises another question. All affected header files are OpenSM
> internals and OpenSM is written in C (not C++). So why 'extern "C"'
> should be here at all? Do you know?
>
>> But the problem is not only
>> with g++ - it is with typing in general. I may be wrong, but I
>> feel that every new gcc version is more strongly typed.
>
> AFAIR (anytype *) to (void *) casting is not needed (doing implicitly)
> in C and this is already part of some basic standards.

True, but the problem is not (anytype *) to (void *) casting.
It's the other way around: (void *) to (anytype *) casting.

-- Yevgeny
  
> Sasha
>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html