From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: [patch 2/2] infiniband/cxgb4: add null check Date: Wed, 02 Jun 2010 21:46:20 -0500 Message-ID: <4C07177C.5050502@opengridcomputing.com> References: <20100531140152.GU5483@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier Cc: Dan Carpenter , Steve Wise , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org Roland Dreier wrote: > > if (status < 0) { > > - ep->com.cm_id->rem_ref(ep->com.cm_id); > > + if (ep->com.cm_id) > > + ep->com.cm_id->rem_ref(ep->com.cm_id); > > Steve, does this make sense? > I actually think that ep->com.cm_id is always valid when connect_reply_upcall() is called. But I'd have to test it more. I'd rather not add this change unless someone convinces me that there actually is a path where the cm_id null... -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html