Name for a new type of QP

Name for a new type of QP

[Moni Shoua]

Hi,
This message follows a discussion in the EWG mailing list.

We want to promote a patch that enables use of a new QP type.
This QP type lets the user post_send() data to its SQ and treat it as the entire packet, including headers.
An example of use with this QP is sending Ethernet packets from userspace (and enjoying kernel bypass).

An open question in this matter it how should we call this QP type.
The first name IBV_QPT_RAW_ETH seems to be too similar to the existing type IBV_QPT_RAW_ETY.

My suggestion (that were posted in a different thread) are

IBV_QPT_FRAME
IBV_QPT_PACKET
IBV_QPT_NOHDR

Please make your comments and send your suggestions.

When we decide about a name we will send a patch that enables the use of this QP type.


thanks

Moni
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Name for a new type of QP

[Walukiewicz, Miroslaw]

I would prefer a name IBV_QPT_FRAME so it is a L2 layerQP. The packet is reserved for L3.

Regards,

Mirek

-----Original Message-----
From: Moni Shoua [mailto:monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org] 
Sent: Wednesday, June 23, 2010 11:20 AM
To: linux-rdma
Cc: Walukiewicz, Miroslaw; Roland Dreier; alexr-smomgflXvOZWk0Htik3J/w@public.gmane.org
Subject: Name for a new type of QP

Hi,
This message follows a discussion in the EWG mailing list.

We want to promote a patch that enables use of a new QP type.
This QP type lets the user post_send() data to its SQ and treat it as the entire packet, including headers.
An example of use with this QP is sending Ethernet packets from userspace (and enjoying kernel bypass).

An open question in this matter it how should we call this QP type.
The first name IBV_QPT_RAW_ETH seems to be too similar to the existing type IBV_QPT_RAW_ETY.

My suggestion (that were posted in a different thread) are

IBV_QPT_FRAME
IBV_QPT_PACKET
IBV_QPT_NOHDR

Please make your comments and send your suggestions.

When we decide about a name we will send a patch that enables the use of this QP type.


thanks

Moni
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Name for a new type of QP

[Alex Rosenbaum]

It is true that on the send path for such a QP you can send any sort of
packet. The user of the QP is required to build the MAC header and the
NIC will wrap the post_sent data in an Ethernet type II frame which
includes the tailing CRC.

On the receive path this QP assume an MAC header. The qp attach GID
value gets the multicast MAC destination address to catch the correct
ingress packets.

Bottom line is that I think IBV_QPT_RAW_ETH is a good name.
If not I would like to recommend to use IBV_QPT_RAW_PACKET which hold a
resemblance to "socket(AF_PACKET, SOCK_RAW,...)"

On the other hand, I never fully understood what does IBV_QPT_RAW_ETY
stand for? Maybe we should change its name to better represent what the
code does.


_________________
 Alex Rosenbaum 

 


-----Original Message-----
From: Walukiewicz, Miroslaw [mailto:Miroslaw.Walukiewicz-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org] 
Sent: Wednesday, June 23, 2010 1:21 PM
To: Moni Shoua; linux-rdma
Cc: Roland Dreier; Alex Rosenbaum
Subject: RE: Name for a new type of QP

I would prefer a name IBV_QPT_FRAME so it is a L2 layerQP. The packet is
reserved for L3.

Regards,

Mirek

-----Original Message-----
From: Moni Shoua [mailto:monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org] 
Sent: Wednesday, June 23, 2010 11:20 AM
To: linux-rdma
Cc: Walukiewicz, Miroslaw; Roland Dreier; alexr-smomgflXvOZWk0Htik3J/w@public.gmane.org
Subject: Name for a new type of QP

Hi,
This message follows a discussion in the EWG mailing list.

We want to promote a patch that enables use of a new QP type.
This QP type lets the user post_send() data to its SQ and treat it as
the entire packet, including headers.
An example of use with this QP is sending Ethernet packets from
userspace (and enjoying kernel bypass).

An open question in this matter it how should we call this QP type.
The first name IBV_QPT_RAW_ETH seems to be too similar to the existing
type IBV_QPT_RAW_ETY.

My suggestion (that were posted in a different thread) are

IBV_QPT_FRAME
IBV_QPT_PACKET
IBV_QPT_NOHDR

Please make your comments and send your suggestions.

When we decide about a name we will send a patch that enables the use of
this QP type.


thanks

Moni
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Name for a new type of QP

[Or Gerlitz]

Alex Rosenbaum wrote:
> I never fully understood what does IBV_QPT_RAW_ETY stand for? Maybe we should change its name to better represent what the code does.
before, maybe take a look on the IB spec... see the spec references 
mentioned by the patch to support IB_QPT_RAW_ETY which posted to the 
list in the past, but didn't make it to upstream yet @ 
http://lists.openfabrics.org/pipermail/general/2008-December/055954.html

Also, IBA  chapter 2, states that "Raw Datagram - A packet that contains 
an IBA Local Route Header, may contain an IBA Global Route Header, but 
does not contain an IBA Transport header, and is not handled by IBA 
transport services",
&& chapter 3, section 3.6.2 "IBA TRANSPORT SERVICES" explains everything 
in detail, including what is the difference between raw ethernet to raw 
ipv6, look for "The Raw Datagram service is not technically a transport 
but rather it is a data link service that allows a QP to send and 
receive raw datagram messages" and following text.

Or.





Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Name for a new type of QP

[Roland Dreier]

 > On the other hand, I never fully understood what does IBV_QPT_RAW_ETY
 > stand for? Maybe we should change its name to better represent what the
 > code does.

Picking names for things is not my strongest suit, and I don't have a
very good suggestion, so I'll leave that out.  But on the point above,
RAW_ETY is for the IBA "raw ethertype" special QP type.  And I think it
would probably be a good idea to change the enum from IBV_QPT_RAW_ETY to
something like IBV_QPT_RAW_ETHERTYPE.

 - R.
-- 
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html