mlx4 pci device table

mlx4 pci device table

[Or Gerlitz]

Hi Yevgeny, Roland

I wonder if you can spare few words what would be the correct location
of the PCI Id table under the two tier architecture of the mlx4 driver?

If the table is placed in mlx4_core (as of today in upstream), then I
assume the mlx4_en and _ib aren't being probed by pci hot-plug
mechasnisms, correct? else if you put it in _en _ib et al files, then
one has to maintain two copies of the table, but maybe this would be
the correct approach? how this should work with multi-protcol mlx4
devices and/or IBoE?

Yevgeny, I see you placed in ofed some patch which isn't upstream
who puts a copy or some modified clone of the table in mlx4_en, what
the problem you were trying to solve?

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: mlx4 pci device table

[Roland Dreier]

 > If the table is placed in mlx4_core (as of today in upstream), then I
 > assume the mlx4_en and _ib aren't being probed by pci hot-plug
 > mechasnisms, correct? else if you put it in _en _ib et al files, then
 > one has to maintain two copies of the table, but maybe this would be
 > the correct approach? how this should work with multi-protcol mlx4
 > devices and/or IBoE?

I think the current upstream location is correct.  This matches the
practice of eg iw_cxgb3 as well as cxgb3i, bnx2i etc.  This does have
the disadvantage that mlx4_en and mlx4_ib are not auto-loaded by PCI
hotplug, but so it goes.
-- 
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: mlx4 pci device table

[Or Gerlitz]

Roland Dreier wrote:
> I think the current upstream location is correct.  This matches the practice of eg iw_cxgb3 as well as cxgb3i, bnx2i etc.  This does have the disadvantage that mlx4_en and mlx4_ib are not auto-loaded by PCI hotplug, but so it goes.
okay. Still, its too bad that ofed ships patches that do things the 
other way around vs upstream. Yevgeny, if you have reasoning in place to 
do things the other way, why not submit upstream?

Or.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: mlx4 pci device table

[Tziporet Koren]

On 6/28/2010 4:11 PM, Or Gerlitz wrote:

> Roland Dreier wrote:
>> I think the current upstream location is correct.  This matches the practice of eg iw_cxgb3 as well as cxgb3i, bnx2i >> etc.  This does have the disadvantage that mlx4_en and mlx4_ib are not auto-loaded by PCI hotplug, but so it goes.

> okay. Still, its too bad that ofed ships patches that do things the 
> other way around vs upstream. Yevgeny, if you have reasoning in place to 
> do things the other way, why not submit upstream?
>
Or
This patch was submitted to upstream but was not accepted.
however without it PXE boot cannot work since only mlx4_core is loaded and not the Eth driver

Any other suggestion how to solve it will be accepted.

Tziporet
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: mlx4 pci device table

[Jason Gunthorpe]

On Mon, Jun 28, 2010 at 10:55:50PM +0300, Tziporet Koren wrote:
> On 6/28/2010 4:11 PM, Or Gerlitz wrote:
> 
> > Roland Dreier wrote:
> >> I think the current upstream location is correct.  This matches the practice of eg iw_cxgb3 as well as cxgb3i, bnx2i >> etc.  This does have the disadvantage that mlx4_en and mlx4_ib are not auto-loaded by PCI hotplug, but so it goes.
> 
> > okay. Still, its too bad that ofed ships patches that do things the 
> > other way around vs upstream. Yevgeny, if you have reasoning in place to 
> > do things the other way, why not submit upstream?

> This patch was submitted to upstream but was not accepted.  however
> without it PXE boot cannot work since only mlx4_core is loaded and
> not the Eth driver

Sigh.. Please realize that creating something which is an aggregation
of stuff that upstream has refused is an extremely bad idea?

> Any other suggestion how to solve it will be accepted.

Yes, you build the initrd properly! All distro initrd scripts have an
option to include named modules, specifically for cases like this. If
you are PXE booting over IB then you need to use those options to
include the mlx driver, ipoib driver, etc, etc.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html