From: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Steve Wise <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Frank Zago
<fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] infiniband: cxgb3: fix signed bug
Date: Mon, 19 Jul 2010 09:45:29 -0500 [thread overview]
Message-ID: <4C446509.3010400@opengridcomputing.com> (raw)
In-Reply-To: <20100717102900.GG17585@bicker>
Dan Carpenter wrote:
> "num_wrs" should be signed so that the "if (num_wrs <= 0)" checks work.
>
> Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_qp.c b/drivers/infiniband/hw/cxgb3/iwch_qp.c
> index ae47bfd..e90fb2d 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_qp.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_qp.c
> @@ -357,7 +357,7 @@ int iwch_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
> struct iwch_qp *qhp;
> u32 idx;
> union t3_wr *wqe;
> - u32 num_wrs;
> + int num_wrs;
> unsigned long flag;
> struct t3_swsq *sqp;
> int wr_cnt = 1;
> @@ -535,7 +535,7 @@ int iwch_bind_mw(struct ib_qp *qp,
> union t3_wr *wqe;
> u32 pbl_addr;
> u8 page_size;
> - u32 num_wrs;
> + int num_wrs;
> unsigned long flag;
> struct ib_sge sgl;
> int err=0;
> @@ -554,7 +554,7 @@ int iwch_bind_mw(struct ib_qp *qp,
> }
> num_wrs = Q_FREECNT(qhp->wq.sq_rptr, qhp->wq.sq_wptr,
> qhp->wq.sq_size_log2);
> - if ((num_wrs) <= 0) {
> + if (num_wrs <= 0) {
> spin_unlock_irqrestore(&qhp->lock, flag);
> return -ENOMEM;
> }
>
The macro Q_FREECNT() must never return <0 or things are badly broken,
so this patch should really leave num_wrs as unsigned and just check for
num_wrs == 0.
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-07-19 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-17 10:29 [patch] infiniband: cxgb3: fix signed bug Dan Carpenter
2010-07-19 14:45 ` Steve Wise [this message]
[not found] ` <4C446509.3010400-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-07-19 20:30 ` [patch v2] infiniband: cxgb3: clean up signed check Dan Carpenter
2010-07-19 22:17 ` Steve Wise
2010-07-21 17:57 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C446509.3010400@opengridcomputing.com \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox