[PATCH 00/10] Add fcoe, fcoib drivers for mlx4 device

[PATCH 00/10] Add fcoe, fcoib drivers for mlx4 device

[Vu Pham]

Hi Roland,

The following series implements fcoe and fcoib offload driver for mlx4 
device

mlx4_fc: implement fcoe/fcoib, hook to scsi mid-layer to offload scsi 
operations, and use openfc's libfc to do ELS/BLS
mlx4_fcoib: driver implement fcoib initialization protocol to discover 
IB-FC gateways/bridges

Yevgeny Petrilin:
    Pre-reserve MTPs for FC
    Attach cq to the least cqs attached completion vector
    Enable T11 bit support in fw
   Add API to query the steer capabilities of mlx4 device
 
Oren Duer:
   Add APIs to mlx4_en/mlx4_ib driver to query interfaces for given 
internal device
   Add MPT reserve/release_range APIs

Vu Pham:
    Enable vlan support in qp path
    Enable mlx4_fc/mlx4_fcoib driver in scsi Kconfig/Makefile
    Add mlx4_fc/mlx4_fcoib drivers 

 drivers/infiniband/hw/mlx4/cq.c       |    4 +-
 drivers/infiniband/hw/mlx4/main.c     |   10 +-
 drivers/net/mlx4/cq.c                 |   27 +-
 drivers/net/mlx4/en_cq.c              |    2 +-
 drivers/net/mlx4/en_main.c            |   14 +
 drivers/net/mlx4/fw.c                 |   13 +
 drivers/net/mlx4/intf.c               |   50 +
 drivers/net/mlx4/main.c               |   10 +-
 drivers/net/mlx4/mlx4.h               |    2 +
 drivers/net/mlx4/mr.c                 |   29 +-
 drivers/scsi/Kconfig                  |   14 +
 drivers/scsi/Makefile                 |    2 +
 drivers/scsi/mlx4_fc/Makefile         |    8 +
 drivers/scsi/mlx4_fc/fcoib.h          |  561 +++++++++
 drivers/scsi/mlx4_fc/fcoib_api.h      |  102 ++
 drivers/scsi/mlx4_fc/fcoib_discover.c | 2003 
+++++++++++++++++++++++++++++++++
 drivers/scsi/mlx4_fc/fcoib_main.c     | 1340 ++++++++++++++++++++++
 drivers/scsi/mlx4_fc/mfc.c            | 1992 
++++++++++++++++++++++++++++++++
 drivers/scsi/mlx4_fc/mfc.h            |  662 +++++++++++
 drivers/scsi/mlx4_fc/mfc_exch.c       | 1502 ++++++++++++++++++++++++
 drivers/scsi/mlx4_fc/mfc_rfci.c       |  990 ++++++++++++++++
 drivers/scsi/mlx4_fc/mfc_sysfs.c      |  243 ++++
 include/linux/mlx4/device.h           |   20 +-
 include/linux/mlx4/driver.h           |   17 +
 include/linux/mlx4/qp.h               |    2 +-
 include/rdma/ib_verbs.h               |   10 +-
 26 files changed, 9606 insertions(+), 23 deletions(-)

Re: [PATCH 00/10] Add fcoe, fcoib drivers for mlx4 device

[Roland Dreier]

Unfortunately it will probably be a while before I can look at this in
any detail, but here are some obvious things to fix:

 - The actual FC/SCSI driver will need to be reviewed on
   linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org of course; so please CC that list.

 - The ordering/split of patches seems off; in particular I notice that
   the patch that adds the new drivers into the build system comes
   before the patch that actually adds the new drivers, which is
   obviously wrong (since the kernel will be broken if we apply patch
   9/10 but not 10/10).

 - None of the patch subjects contain a subject that says what part of
   the kernel they touch.  For example, instead of

    "[PATCH 01/10]  pre-reserve MPTs for FC"

   please write:

    "[PATCH 01/10] mlx4_core: Pre-reserve MPTs for FC"

   otherwise I waste time having to fix it up by hand.  (And also if you
   want to do things exactly write, please capitalize the subject but do
   not put in a final '.'  But I usually do not complain about that
   level of detail)

 - Every patch seems to have the changelog and diffstat twice.  Please
   fix (and include a "---" between the changelog and diffstat).  If you
   prepare a clean git tree, then git format-patch will get everything
   exactly correct.

 - There seem to be a lot of whitespace and other formatting problems.
   Please run patches through checkpatch.pl and fix any real problems
   that it finds (0 warnings are not necessary since some warnings are
   false positives; but I suspect for these patches most won't be).
-- 
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html