public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Yevgeny Kliteynik <kliteyn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>,
	Linux RDMA <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Subject: Multicast group pre-creation for TopSpin old stack
Date: Sun, 05 Sep 2010 12:07:43 +0300	[thread overview]
Message-ID: <4C835DDF.6000809@dev.mellanox.co.il> (raw)

Sasha,

There's a hack in the SM to deal with TopSpin's non-compliant
join compmask for IPoIB v4 multicast group ff12:401b:<pkey>::1
The group is pre-defined and maintained as a well-known multicast
group.

opensm/osm_prtn.c:

   232          /* workaround for TS */
   233          /* FIXME: remove this upon TS fixes */
   234          mc_rec.mgid = osm_ts_ipoib_mgid;
   235          memcpy(&mc_rec.mgid.raw[4], &pkey, sizeof(pkey));
   236          /* Scope in MCMemberRecord (if present) needs to be consistent with MGID */
   237          mc_rec.scope_state = ib_member_set_scope_state(scope, IB_MC_REC_STATE_FULL_MEMBER);
   238          ib_mgid_set_scope(&mc_rec.mgid, scope);
   239
   240          status = osm_mcmr_rcv_find_or_create_new_mgrp(p_sa, comp_mask, &mc_rec,
   241                                                        &p_mgrp);
   242          if (p_mgrp) {
   243                  p_mgrp->well_known = TRUE;
   244                  if (!p->mgrp)
   245                          p->mgrp = p_mgrp;
   246          }

As far as I can tell, this was added before git history.
Any idea if it's still needed?

-- Yevgeny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2010-09-05  9:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-05  9:07 Yevgeny Kliteynik [this message]
     [not found] ` <4C835DDF.6000809-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2010-09-06 16:43   ` Multicast group pre-creation for TopSpin old stack Sasha Khapyorsky
2010-09-06 23:55     ` Hal Rosenstock
     [not found]       ` <AANLkTinG2XEhJkYYf-kZGYx7h8wJnBcywMa4AS-KaVh4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-07  0:13         ` Roland Dreier
     [not found]           ` <adazkvul8ay.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-09-07 16:51             ` Sasha Khapyorsky
2010-09-07 17:19               ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C835DDF.6000809@dev.mellanox.co.il \
    --to=kliteyn-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    --cc=sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox