From: Yevgeny Kliteynik <kliteyn-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
To: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>,
Linux RDMA <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH] opensm/osm_mtree.c: removing useless 'if' statement
Date: Tue, 7 Sep 2010 17:53:54 +0300 [thread overview]
Message-ID: <4C865202.9020105@mellanox.co.il> (raw)
p_mtn->max_children is an array - no point checking if it is NULL.
Signed-off-by: Yevgeny Kliteynik <kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
---
opensm/opensm/osm_mtree.c | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/opensm/opensm/osm_mtree.c b/opensm/opensm/osm_mtree.c
index b5ce73b..693d0d5 100644
--- a/opensm/opensm/osm_mtree.c
+++ b/opensm/opensm/osm_mtree.c
@@ -73,11 +73,10 @@ void osm_mtree_destroy(IN osm_mtree_node_t * p_mtn)
if (p_mtn == NULL)
return;
- if (p_mtn->child_array != NULL)
- for (i = 0; i < p_mtn->max_children; i++)
- if ((p_mtn->child_array[i] != NULL) &&
- (p_mtn->child_array[i] != OSM_MTREE_LEAF))
- osm_mtree_destroy(p_mtn->child_array[i]);
+ for (i = 0; i < p_mtn->max_children; i++)
+ if ((p_mtn->child_array[i] != NULL) &&
+ (p_mtn->child_array[i] != OSM_MTREE_LEAF))
+ osm_mtree_destroy(p_mtn->child_array[i]);
free(p_mtn);
}
--
1.6.2.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2010-09-07 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 14:53 Yevgeny Kliteynik [this message]
[not found] ` <4C865202.9020105-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
2010-09-07 20:04 ` [PATCH] opensm/osm_mtree.c: removing useless 'if' statement Sasha Khapyorsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C865202.9020105@mellanox.co.il \
--to=kliteyn-vpraknaxozvs1mouv/rt9w@public.gmane.org \
--cc=kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox