From: Or Gerlitz <ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Ralph Campbell <ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>
Cc: "Hefty,
Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 3/3] ibacm: check for special handling of loopback requests
Date: Wed, 17 Nov 2010 10:33:53 +0200 [thread overview]
Message-ID: <4CE39371.8030306@voltaire.com> (raw)
In-Reply-To: <1289957852.9693.7.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org>
Ralph Campbell wrote:
> I guess what I'm objecting to is hard coding mlx4. I was trying to think of a way that would allow other HCAs to support the block loopback option in the future. It looks like ipoib sets IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK for kernel QPs but this isn't defined in libibverbs yet. It seems reasonable to add that feature some time in the future and change ibacm to use it. In the mean time, I guess I don't see an alternative to your patch.
Ralph, Sean
Its been couple of years since some folks from Voltaire tried to push
this flag and the grounds for adding similar flags for QP creation, on
the bright side, its there for kernel consumers where existing flags are
LSO, block-multicast-loopback. On the somehow disappointing side, we
didn't get that merged for user space. Basically, there was a claim on
dependency with XRC patch set which also added flags for QPs, at some
point, Ron Livne managed to introduce patch set which is independent of
the XCR, see (*) below, but it didn't get in. As such one of our
application teams pushed to ofed that mlx4 patch which sets this bit by
default and the acm code is trying to identify and act upon its
existence (**)
Or.
(*) latest post of the patch set
0/4: https://kerneltrap.org/mailarchive/openfabrics-general/2008/12/11/4392994
1/4: https://kerneltrap.org/mailarchive/openfabrics-general/2008/12/11/4393054
2/4: https://kerneltrap.org/mailarchive/openfabrics-general/2008/12/11/4393004
3/4: https://kerneltrap.org/mailarchive/openfabrics-general/2008/12/11/4393014
4/4: https://kerneltrap.org/mailarchive/openfabrics-general/2008/12/11/4393024
(**) ofed patch
http://git.openfabrics.org/git?p=ofed_1_5/linux-2.6.git;a=blob;f=kernel_patches/fixes/mlx4_0290_mcast_loopback.patch;h=786a3926529befac2c2d1fa6d8c36bada79d61a7;hb=HEAD <http://git.openfabrics.org/git?p=ofed_1_5/linux-2.6.git;a=blob;f=kernel_patches/fixes/mlx4_0290_mcast_loopback.patch;h=786a3926529befac2c2d1fa6d8c36bada79d61a7;hb=HEAD>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-11-17 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 0:10 [PATCH 1/3] ibacm: enhance debug messages Hefty, Sean
[not found] ` <CF9C39F99A89134C9CF9C4CCB68B8DDF25B86168B9-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-11-17 0:12 ` [PATCH 2/3] ibacm: fix issuing SA query after recording address Hefty, Sean
2010-11-17 0:15 ` [PATCH 3/3] ibacm: check for special handling of loopback requests Hefty, Sean
[not found] ` <CF9C39F99A89134C9CF9C4CCB68B8DDF25B86168CE-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-11-17 0:31 ` Ralph Campbell
[not found] ` <1289953873.2365.179.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org>
2010-11-17 0:54 ` Hefty, Sean
[not found] ` <CF9C39F99A89134C9CF9C4CCB68B8DDF25B8616939-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-11-17 1:08 ` Ralph Campbell
[not found] ` <1289956127.2365.190.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org>
2010-11-17 1:24 ` Hefty, Sean
[not found] ` <CF9C39F99A89134C9CF9C4CCB68B8DDF25B8616977-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-11-17 1:37 ` Ralph Campbell
[not found] ` <1289957852.9693.7.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org>
2010-11-17 8:33 ` Or Gerlitz [this message]
2010-11-17 17:11 ` Hefty, Sean
2010-11-17 8:36 ` Or Gerlitz
[not found] ` <4CE39429.6030202-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-11-17 15:25 ` Hefty, Sean
2010-11-17 18:39 ` [PATCH 3/3 v2] ibacm: Introduce loopback resolution 'protocol' Hefty, Sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE39371.8030306@voltaire.com \
--to=ogerlitz-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox